-
Notifications
You must be signed in to change notification settings - Fork 514
WWSTCERT-8408 add HOPOsmart window opener A2230011 #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WWSTCERT-8408 add HOPOsmart window opener A2230011 #2465
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 459 suites 0s ⏱️ Results for commit 821eb23. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 821eb23 |
bce2e34 to
8261d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a fairly generic profile, please use a fairly generic name.
I'd suggest window-shade-only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a fairly generic profile, please use a fairly generic name.
I'd suggest
window-shade-only.
Hi, @greens . The category of this profile is WindowOpener rather than the more generic Window. Would it be fine to change the profile name to window-shade-only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the profile name change, this looks good, but you will need to rebase your branch to incorporate upstream changes and eliminate merge conflicts.
8261d47 to
821eb23
Compare
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests