Skip to content

feat(datapools): fix namespace parsing for nkv #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alaa-eddine-k merged 1 commit into from
Dec 8, 2025
Merged

feat(datapools): fix namespace parsing for nkv #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/Components/RAG/DataSourceCleaner.class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ export class DataSourceCleaner extends DataSourceComponent {
const namespaceLabel = /^c[a-z0-9]{24}.+$/.test(configSchema.value.namespaceId)
? configSchema.value.namespaceId.split('_').slice(1).join('_')
: configSchema.value.namespaceId;
const namespaceId = configSchema.value.namespaceId;
// const namespaceId = configSchema.value.namespaceId;

let vecDbConnector: VectorDBConnector = null;
try {
vecDbConnector = await this.resolveVectorDbConnector(namespaceId, teamId);
vecDbConnector = await this.resolveVectorDbConnector(namespaceLabel, teamId);
} catch (err: any) {
debugOutput += `Error: ${err?.message || "Couldn't get vector database connector"}\n\n`;
return {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/Components/RAG/DataSourceIndexer.class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,12 +150,12 @@ export class DataSourceIndexer extends DataSourceComponent {
// we try to get the namespace without the prefix teamId, if not exist, we use the full namespace id
// const namespaceLabel = _config.namespace.split('_').slice(1).join('_') || _config.namespace;
const namespaceLabel = /^c[a-z0-9]{24}.+$/.test(_config.namespace) ? _config.namespace.split('_').slice(1).join('_') : _config.namespace;
const namespaceId = _config.namespace;
// const namespaceId = _config.namespace;
debugOutput += `[Selected namespace] \n${namespaceLabel}\n\n`;

let vecDbConnector: VectorDBConnector = null;
try {
vecDbConnector = await this.resolveVectorDbConnector(namespaceId, teamId);
vecDbConnector = await this.resolveVectorDbConnector(namespaceLabel, teamId);
} catch (err: any) {
debugOutput += `Error: ${err?.message || "Couldn't get vector database connector"}\n\n`;
return {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/Components/RAG/DataSourceLookup.class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export class DataSourceLookup extends DataSourceComponent {
const namespaceLabel = /^c[a-z0-9]{24}.+$/.test(config.data.namespace)
? config.data.namespace.split('_').slice(1).join('_')
: config.data.namespace;
const namespaceId = config.data.namespace;
// const namespaceId = config.data.namespace;
const model = config.data?.model || 'gpt-4o-mini';
const includeMetadata = config.data?.includeMetadata || false;

Expand All @@ -175,7 +175,7 @@ export class DataSourceLookup extends DataSourceComponent {
// let vectorDbConnector = ConnectorService.getVectorDBConnector();
// let existingNs = await vectorDbConnector.requester(AccessCandidate.team(teamId)).namespaceExists(namespaceLabel);

const vecDbConnector = await this.resolveVectorDbConnector(namespaceId, teamId);
const vecDbConnector = await this.resolveVectorDbConnector(namespaceLabel, teamId);

let results: string[] | { content: string; metadata: any; score?: number }[];
let _error;
Expand Down