-
Notifications
You must be signed in to change notification settings - Fork 265
feat: support private key env. #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
), # TODO: Remove when connections.toml is enforced | ||
"private_key_file_pwd": kwargs.get( | ||
"private_key_file_pwd" | ||
), # TODO: Remove when connections.toml is enforced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement should not be removed even after connections.toml is enforced. Since, we will not want to write the private key passphrase into a file even then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed to use private_key_path, and removed comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My team is waiting for PASSPHRASE support to be released.
Is there anything else I can do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ya7010 shouldn't we go all the way to just supporting SNOWFLAKE_PRIVATE_KEY
as an env variable instead of SNOWFLAKE_PRIVATE_KEY_PATH
(avoiding materializing the key all together)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mibelbahri
Are you referring to using SNOWFLAKE_PRIVATE_KEY instead of SNOWFLAKE_PRIVATE_KEY_PATH?
I think SNOWFLAKE_PRIVATE_KEY_PASSPHRASE should be retained.
Is there anything I can do to help merge this PR? |
After updating from 3.7.0 to 4.0.1, authentication by keypath now gives an error.
This PR restores the implementation that recognizes
SNOWFLAKE_PRIVATE_KEY_PATH
,SNOWFLAKE_PRIVATE_KEY_PASSPHRASE
.The GitHub Action workflow we used is as follows:
Since Snowflake is discontinuing single-factor password authentication, my team has moved to Key/Pair authentication.