Merged
Conversation
…ve exchange rate calculation
…ive exchange rate calculation
- change tickBlock and ownerShareOfInterest to uint128 for consitency - optimize block number handling
…r for consistency
…dy present in Launchpool
…nt excessive linting
… LaunchpoolFactory
…tead of block.timestamp
…e in stake and unstake funcs
…int for test and scripts
…PendingExchangeRate()
… at once (batch deployment)
…correct exchange rate gradient" This reverts commit a0c0a49.
…pgradeable contracts
…raries on Moonbase
…and enhance error handling
DxcMint868
approved these changes
Apr 28, 2025
Member
DxcMint868
left a comment
DxcMint868
left a comment
There was a problem hiding this comment.
LGTM,
MERGE APPROVED🛡️
Be it, may the battle-testing march begins.
Sun may rise,
Wind shall blows.
What does thy future hold?
Thee could never have foretold.
Code forged in silence.
Deployed in chaos.
Ahead lies crucibles, outages, rollback fires, user wrath.
It is indeed calm before the storm
But we?
We do not fear the storm.
We are the storm.
Let the code face the fire.
Let the weak functions burn.
Let the strong ones ascend.
Tribute to our soldiers who never once folded
Today we merge.
Tomorrow we conquer.
God Blessed.
- Minh Duc, to all our fellow builders -
DxcMint868
approved these changes
Apr 28, 2025
Member
DxcMint868
left a comment
DxcMint868
left a comment
There was a problem hiding this comment.
LGTM, APPROVED
Massive,
God Blessed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract have developed, when through unit test, fuzz test and on-chain manual test