Skip to content

P2-T1: Replace --broker-spawn/--broker-connect with single --broker flag#125

Merged
SoundBlaster merged 9 commits intomainfrom
feature/P2-T1-broker-flag
Mar 1, 2026
Merged

P2-T1: Replace --broker-spawn/--broker-connect with single --broker flag#125
SoundBlaster merged 9 commits intomainfrom
feature/P2-T1-broker-flag

Conversation

@SoundBlaster
Copy link
Owner

Description

Adds a single --broker flag as the recommended way to enable broker mode. It auto-detects whether a daemon is alive and connects to it, or spawns one if absent — the same behaviour as --broker-spawn today. --broker-spawn and --broker-connect are kept as working legacy aliases for backwards compatibility.

Changes:

  • src/mcpbridge_wrapper/__main__.py_parse_broker_args recognises --broker (sets broker_spawn=True, broker_connect=True, identical to --broker-spawn)
  • README.md — all MCP settings examples for Cursor, Claude Code, and Codex CLI updated from --broker-spawn to --broker; broker mode reference section updated with recommended/legacy guidance
  • tests/unit/test_main.py — 4 new tests covering --broker flag parsing and main() integration

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • CI/CD improvement

Quality Gates

  • make test - All tests pass with ≥90% coverage (678 passed, 91.41% coverage)
  • make lint - No linting errors (ruff check src/ passed)
  • make format - Code is properly formatted
  • make typecheck - Type checking passes
  • make doccheck - Documentation is synced with DocC (if docs changed)

Documentation Sync

  • Documentation changes are synced with DocC catalog (or N/A) — DocC catalog contains no --broker-spawn references; README updated

Testing

  • Added/updated tests for new functionality (4 new unit tests)
  • All tests pass locally (678 passed, 0 failures)
  • Manually tested the changes

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • Comments added for complex code
  • Documentation updated (if needed)
  • No new warnings generated
  • PR title is descriptive

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@SoundBlaster SoundBlaster merged commit 1579524 into main Mar 1, 2026
10 checks passed
@SoundBlaster SoundBlaster deleted the feature/P2-T1-broker-flag branch March 1, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant