P2-T1: Replace --broker-spawn/--broker-connect with single --broker flag#125
Merged
SoundBlaster merged 9 commits intomainfrom Mar 1, 2026
Merged
P2-T1: Replace --broker-spawn/--broker-connect with single --broker flag#125SoundBlaster merged 9 commits intomainfrom
SoundBlaster merged 9 commits intomainfrom
Conversation
…le --broker flag (PASS)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a single
--brokerflag as the recommended way to enable broker mode. It auto-detects whether a daemon is alive and connects to it, or spawns one if absent — the same behaviour as--broker-spawntoday.--broker-spawnand--broker-connectare kept as working legacy aliases for backwards compatibility.Changes:
src/mcpbridge_wrapper/__main__.py—_parse_broker_argsrecognises--broker(setsbroker_spawn=True, broker_connect=True, identical to--broker-spawn)README.md— all MCP settings examples for Cursor, Claude Code, and Codex CLI updated from--broker-spawnto--broker; broker mode reference section updated with recommended/legacy guidancetests/unit/test_main.py— 4 new tests covering--brokerflag parsing andmain()integrationType of Change
Quality Gates
make test- All tests pass with ≥90% coverage (678 passed, 91.41% coverage)make lint- No linting errors (ruff check src/passed)make format- Code is properly formattedmake typecheck- Type checking passesmake doccheck- Documentation is synced with DocC (if docs changed)Documentation Sync
--broker-spawnreferences; README updatedTesting
Checklist