Fix broker auto-spawn when stale non-broker PID file blocks spawn#142
Merged
SoundBlaster merged 4 commits intomainfrom Mar 6, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03280570b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
~/.mcpbridge_wrapper/broker.pidcontained a live but unrelated PID, causing IDE clients to fail to start MCP while direct mode still worked.os.kill(pid, 0)liveness check without verifying the process identity, which allowed unrelated processes to short-circuit spawn logic.Description
BrokerProxy._spawn_broker_if_needed: if a live PID is present but_pid_belongs_to_broker(pid)returnsFalse, the proxy now logs a warning and calls_cleanup_broker_files()so normal socket-check / spawn flow proceeds.test_live_non_broker_pid_is_treated_as_staleand update related tests to explicitly mock_pid_belongs_to_brokerwhere appropriate to reflect the new logic.Testing
PYTHONPATH=src pytest -q tests/unit/test_broker_proxy.pyand all tests passed:57 passed.PYTHONPATH=src ruff check src/mcpbridge_wrapper/broker/proxy.py tests/unit/test_broker_proxy.pyand linting passed.python -m py_compile src/mcpbridge_wrapper/broker/proxy.py(success).Codex Task