Expand PID recognition for broker daemon and clean non-broker PIDs before spawn#143
Closed
SoundBlaster wants to merge 1 commit intomainfrom
Closed
Expand PID recognition for broker daemon and clean non-broker PIDs before spawn#143SoundBlaster wants to merge 1 commit intomainfrom
SoundBlaster wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_pid_belongs_to_brokerto require the--broker-daemontoken and accept multiple executable name tokens ("mcpbridge_wrapper","mcpbridge-wrapper", and"xcodemcpwrapper")._spawn_broker_if_neededto check_pid_belongs_to_brokerand clean stale files when a live PID does not belong to the broker, and to rearrange the version-mismatch logic accordingly.Testing
pytest tests/unit/test_broker_proxy.py, which includes the new teststest_pid_belongs_to_broker_true_for_console_script_command,test_pid_belongs_to_broker_true_for_legacy_wrapper_command, andtest_live_non_broker_pid_is_treated_as_stale.Codex Task