Skip to content

fix Crash detail: #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix Crash detail: #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2504d8
Fix : FlattenedProvider misplace，e.g. 110 meybe 1-1-0 or 11-0
Mar 4, 2019
e9a429b
Update CollectionReuseViewManager.swift
dishcool Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Sources/Other/CollectionReuseViewManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ public class CollectionReuseViewManager: NSObject {
} else {
reusableViews[identifier] = [view]
}
if let collectionView = view as? CollectionView {
collectionView.provider = nil
}
if let cleanupTimer = cleanupTimer {
cleanupTimer.fireDate = Date().addingTimeInterval(lifeSpan)
} else {
Expand Down
2 changes: 1 addition & 1 deletion Sources/Provider/FlattenedProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ struct FlattenedProvider: ItemProvider {
func identifier(at: Int) -> String {
let (sectionIndex, item) = indexPath(at)
if let sectionData = childSections[sectionIndex].sectionData {
return provider.identifier(at: sectionIndex) + sectionData.identifier(at: item)
return provider.identifier(at: sectionIndex) + "-" + sectionData.identifier(at: item)
} else {
return provider.identifier(at: sectionIndex)
}
Expand Down