Skip to content

Right fixed keys #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Christian-B merged 4 commits into from
Apr 15, 2026
Merged

Right fixed keys #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97898ee
allocate no longer takes a param
Christian-B Mar 9, 2026
8d667a8
merged in master
Christian-B Mar 10, 2026
0754a86
add a report
Christian-B Mar 19, 2026
c206e4e
replace n_bit_atoms with machine_shift
Christian-B Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spynnaker/pyNN/models/common/local_only_2d_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def get_rinfo_for_spike_source(
if n_cores == 1 or isinstance(pre_vertex, ApplicationVirtualVertex):
return r_info, 0, 0

mask_shift = r_info.n_bits_atoms
mask_shift = r_info.machine_shift
core_mask = (2 ** get_n_bits(n_cores)) - 1
return r_info, core_mask, mask_shift

Expand Down
2 changes: 1 addition & 1 deletion spynnaker/pyNN/models/neuron/synaptic_matrices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ def __get_app_key_and_mask(
n_atoms = 0
else:
# Find the part that is just for the core
mask_size = r_info.n_bits_atoms
mask_size = r_info.machine_shift
core_mask = (2 ** allocator_bits_needed(
len(r_info.vertex.splitter.get_out_going_vertices(
partition_id)))) - 1
Expand Down
1 change: 1 addition & 0 deletions spynnaker_integration_tests/test_onchip_compressor/test_pair/spynnaker.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ write_compressed = True
write_compression_comparison = True
write_compression_summary = True
write_energy_report = False
write_router_info_report = True

[Mode]
mode = Production
4 changes: 2 additions & 2 deletions unittests/model_tests/neuron/test_synaptic_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def test_write_data_spec() -> None:
writer.add_edge(edge, part_id)
splitter_partitioner()
allocator = ZonedRoutingInfoAllocator()
writer.set_routing_infos(allocator.allocate([]))
writer.set_routing_infos(allocator.allocate())

post_vertex = next(iter(post_pop._vertex.machine_vertices))
post_vertex_slice = post_vertex.vertex_slice
Expand Down Expand Up @@ -466,7 +466,7 @@ def test_pop_based_master_pop_table_standard(
writer.add_edge(edge, part_id)
splitter_partitioner()
allocator = ZonedRoutingInfoAllocator()
writer.set_routing_infos(allocator.allocate([]))
writer.set_routing_infos(allocator.allocate())

post_mac_vertex = next(iter(post_pop._vertex.machine_vertices))
post_vertex_slice = post_mac_vertex.vertex_slice
Expand Down
Loading