cache the index used to make call repeatable#1661
Open
Christian-B wants to merge 1 commit intomasterfrom
Open
Conversation
Member
Author
|
Found by and tested by SpiNNakerManchester/PACMAN#627 but independant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplitterPopulationVertexNeuronsSynapses.get_source_specific_in_coming_vertices
Assumes the method is only called once per source_vertex, partition_id pair.
In practice this assumption holds.
BUT if something like
pacman/operations/multi_cast_router_check_functionality/valid_routes_checker.py
may call it a second time with the same pair.
This pr caches the minimum data needed to make the call repeatable.
Faster alternative are available caching more data but as in normal operation the cache is not needed the choice was for size vs speed.