Skip to content

cache the index used to make call repeatable#1661

Open
Christian-B wants to merge 1 commit intomasterfrom
validate_routes_uncompressed
Open

cache the index used to make call repeatable#1661
Christian-B wants to merge 1 commit intomasterfrom
validate_routes_uncompressed

Conversation

@Christian-B
Copy link
Copy Markdown
Member

SplitterPopulationVertexNeuronsSynapses.get_source_specific_in_coming_vertices

Assumes the method is only called once per source_vertex, partition_id pair.

In practice this assumption holds.

BUT if something like
pacman/operations/multi_cast_router_check_functionality/valid_routes_checker.py

may call it a second time with the same pair.

This pr caches the minimum data needed to make the call repeatable.

Faster alternative are available caching more data but as in normal operation the cache is not needed the choice was for size vs speed.

@Christian-B
Copy link
Copy Markdown
Member Author

Found by and tested by SpiNNakerManchester/PACMAN#627 but independant

@Christian-B Christian-B requested a review from rowleya April 7, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants