Relocate dependencies within the processor jar#593
Open
SquidDev wants to merge 1 commit intoSpongePowered:masterfrom
Open
Relocate dependencies within the processor jar#593SquidDev wants to merge 1 commit intoSpongePowered:masterfrom
SquidDev wants to merge 1 commit intoSpongePowered:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an annotation processor depends on a more recent version of one of Mixin's dependencies, it's possible that the outdated class from Mixin's processor jar will be used instead, resulting in
NoSuchMethodErrors during compilation.Instead, we relocate the shadowed dependencies to live within the
org.spongepowered.asm.shadowpackage instead, allowing them to co-exist with other processors.