Skip to content

Sync health and food to clients when interact block secondary event is cancelled #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: api-12
Choose a base branch
from
Open

Sync health and food to clients when interact block secondary event is cancelled #4221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda20f6
Sync health and food to clients when interact block secondary event i…
AlexandreArcil Aug 10, 2025
7b5fcba
getExhaustionLevel was used instance of getSaturationLevel
AlexandreArcil Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...rg/spongepowered/common/mixin/tracker/server/level/ServerPlayerGameModeMixin_Tracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@
import com.llamalad7.mixinextras.sugar.Share;
import com.llamalad7.mixinextras.sugar.ref.LocalBooleanRef;
import com.llamalad7.mixinextras.sugar.ref.LocalRef;
import net.minecraft.network.protocol.game.ClientboundSetHealthPacket;
import net.minecraft.server.level.ServerPlayer;
import net.minecraft.server.level.ServerPlayerGameMode;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResult;
import net.minecraft.world.ItemInteractionResult;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.food.FoodData;
import net.minecraft.world.inventory.AbstractContainerMenu;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.Level;
Expand Down Expand Up @@ -103,10 +105,18 @@ public abstract class ServerPlayerGameModeMixin_Tracker {
final Vector3d hitVec = VecHelper.toVector3d(blockHit.getLocation());
final org.spongepowered.api.util.Direction direction = DirectionFacingProvider.INSTANCE.getKey(blockHit.getDirection()).get();
final InteractBlockEvent.Secondary event = SpongeCommonEventFactory.callInteractBlockEventSecondary(player, stack, hitVec, snapshot, direction, hand);
final FoodData foodData = player.getFoodData();
final float prevHealth = player.getHealth();
final int prevFoodLevel = foodData.getFoodLevel();
final float prevSaturationLevel = foodData.getSaturationLevel();

((ServerPlayerGameModeBridge) this).bridge$setInteractBlockRightClickCancelled(event.isCancelled());
if (event.isCancelled()) {
this.player.inventoryMenu.sendAllDataToRemote();
// Cancel health or food level changes to the client, for example after eating a cake
if (player.getHealth() != prevHealth || foodData.getFoodLevel() != prevFoodLevel || foodData.getSaturationLevel() != prevSaturationLevel) {
this.player.connection.send(new ClientboundSetHealthPacket(player.getHealth(), foodData.getFoodLevel(), foodData.getSaturationLevel()));
}
return InteractionResult.FAIL;
}

Expand Down
Loading