Skip to content

Conversation

@mas-4
Copy link

@mas-4 mas-4 commented Aug 11, 2023

This is to help people avoid having to dig through issues to find #558

Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the late reply.

That should definitely improve the situation. Another potentially easier solution would be to disable MPRIS via the config, maybe that could be recommended instead?

@mas-4
Copy link
Author

mas-4 commented Aug 17, 2023

I'm not sure. To be honest, it had been over a year since the last time I'd upgraded and accidentally chose the wrong version to upgrade with (I was experiencing frequent disconnections).

If it was a configuration feature to prevent this error, I'd still hit it because I don't have that config flag. So if you decide that's the best route, you'll still need to modify the error message to make it easier, though the error message would be simpler to suggest "Please add disable_mpris=1" to your config if this is expected."

@eladyn
Copy link
Member

eladyn commented Aug 17, 2023

Yeah, modifying the error message would still make sense and I was hoping you might want to do it. 🙈 If you don't have the time or motivation, that's fine as well, and I'll eventually get around to do that some time in thw future. 🙂

@mas-4
Copy link
Author

mas-4 commented Aug 23, 2023

I can take a crack at it. I'm unfamiliar with the config system and am a rust noob but I will try this weekend. I like Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants