Allow datastore key to be populated from a variable. #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
punkrokk
approved these changes
Dec 22, 2020
amanda11
reviewed
Dec 22, 2020
Contributor
amanda11
left a comment
amanda11
left a comment
There was a problem hiding this comment.
LGTM - just a minor comment on the wording in the documentation.
nmaludy
force-pushed
the
feature/datastore-keys
branch
from
b72aaee to
850e7ba
Compare
punkrokk
approved these changes
Dec 22, 2020
arm4b
suggested changes
Dec 22, 2020
| become: yes | ||
| copy: | ||
| content: "{{ st2_datastore_key }}" | ||
| dest: "{{ st2_datastore_key_file }}" |
Member
There was a problem hiding this comment.
When the content of the file changes we'll need to notify st2 to restart the services.
According to code below it's st2api, but I guess that's incomplete as more StackStorm services might be using the crypto key.
Member
Author
There was a problem hiding this comment.
@armab added a restart to all of the st2 services
Member
There was a problem hiding this comment.
Restarting all the st2 services is impractical here. We need only specific services that are using st2 datastore key.
Can you please figure out which may use it?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if installing StackStorm in a multi-node environment, it would generate a new datastore key on every node.
This change allows the datastore key to be specified as a variable
st2_datastore_keythen propagated to each host.By default, this variable is
nulland will result in a random key being generated (retaining same behavior).