Skip to content

Support SSH agent fwd for actionrunner on macos #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k-willowhawk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support SSH agent fwd for actionrunner on macos #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ services:
- st2api
networks:
- private
environment:
- SSH_AUTH_SOCK=/ssh-agent
volumes:
- /run/host-services/ssh-auth.sock:/ssh-agent
Copy link
Member

@cognifloyd cognifloyd Jul 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do something more generic?
On my linux box I have something like:
SSH_AUTH_SOCK=/tmp/ssh-XXXXXXs4KUHi/agent.1234

So, is there a way to avoid hard-coding this path?

Copy link
Member

@cognifloyd cognifloyd Jul 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know docker-compose very well, but would something like this work?

Suggested change
- /run/host-services/ssh-auth.sock:/ssh-agent
- ${SSH_AUTH_SOCK:-/run/host-services/ssh-auth.sock}:/ssh-agent

Copy link
Member

@arm4b arm4b Jul 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

Another thought is how to make it optional?

I'm thinking that majority of the users might not need these volume mounts by default
So we avoid sharing the ssh auth socket with st2 unless configured.

- ./files/st2.docker.conf:/etc/st2/st2.docker.conf:ro
- ./files/st2.user.conf:/etc/st2/st2.user.conf:ro
- stackstorm-packs-configs:/opt/stackstorm/configs:rw
Expand Down