[Feature] surport explain return type #63723
Open
+172
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
luoyuanluoyuan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| return GsonUtils.GSON.newBuilder().disableHtmlEscaping() | ||
| .create().toJson(queryColumnTypes); | ||
| } |
There was a problem hiding this comment.
Bug: Incomplete Type Information in EXPLAIN Output
The getColumnTypeExplain method only adds type information for SlotRef expressions. This omits non-SlotRef expressions (e.g., computed columns, literals, function calls) from the result, leading to an incomplete and inconsistent EXPLAIN TYPE output that doesn't match the query's actual columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #63716
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Introduces
EXPLAIN TYPEto output query result column names/types as JSON, with parser, executor, plan support, and tests.TYPEto output query result column schema as JSON.StmtExecutor.buildExplainString(...): when level isTYPE, returns column types JSON; suppresses "EXECUTE IN FE" prefix for TYPE.StarRocks.g4) to acceptTYPEinEXPLAIN.AstBuilder: mapEXPLAIN TYPEtoStatementBase.ExplainLevel.TYPE.StatementBase: addTYPEtoExplainLevelenum.ExecPlan.getColumnTypeExplain(...): produce JSON array of{columnName,columnType}from output expressions; logs non-slot refs.QueryColumnType(name/type with Gson annotations).GetQueryColumnPlanTest: validates JSON schema output andexplain typepath.Written by Cursor Bugbot for commit 13d073a. This will update automatically on new commits. Configure here.