Skip to content

Conversation

@wuxueyang96
Copy link
Contributor

Why I'm doing:

After #65304 merged, if creating table with table properties replicated_storage in cloud native mode, no matter it is true or not, it will throw exception like 'Unknown properties: replicated_storage' because the PropertyAnalyzer will analyze properties and remove it from properties map which will be check empty when finishing processing creating table.

What I'm doing:

Always analyze replicated_storage property but never set in cloud native table.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

@wuxueyang96 wuxueyang96 changed the title [Stella][BugFix] always analyze replicated storage [Stella][Bugfix] always analyze replicated storage Nov 20, 2025
@wuxueyang96 wuxueyang96 changed the title [Stella][Bugfix] always analyze replicated storage [Bugfix] always analyze replicated storage Nov 20, 2025
@wuxueyang96 wuxueyang96 changed the title [Bugfix] always analyze replicated storage [BugFix] always analyze replicated storage Nov 20, 2025
@wuxueyang96 wuxueyang96 force-pushed the fix_replicated_storage branch from fa616cf to 7f6e0f3 Compare November 24, 2025 02:00
@sonarqubecloud
Copy link

@github-actions
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions
Copy link

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/server/OlapTableFactory.java 2 2 100.00% []

@github-actions
Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants