[BugFix]Fix filesystem cache failure.

[zhangheihei]

Why I'm doing:

1. select takes 0.06s

919 rows in set (0.06 sec)

mysql> 
mysql> 
mysql> select * from ads_member_integral_dashboard_1day_new;

2. set starlet_filesystem_instance_cache_capacity to 0

mysql> update information_schema.be_configs set value = 0 where name = "starlet_filesystem_instance_cache_capacity";
Query OK, 0 rows affected (0.17 sec)

3. select takes 24.33s

919 rows in set (24.33 sec)

mysql> select * from ads_member_integral_dashboard_1day_new;

4. set starlet_filesystem_instance_cache_capacity to 10000

mysql> update information_schema.be_configs set value = 10000 where name = "starlet_filesystem_instance_cache_capacity";
Query OK, 0 rows affected (0.02 sec)

5. select still takes

919 rows in set (21.30 sec)

mysql> select * from ads_member_integral_dashboard_1day_new;

6. create new table from ads_member_integral_dashboard_1day_new

create table a01 as select * from ads_member_integral_dashboard_1day_new;
Query OK, 919 rows affected (23.72 sec)
{'label':'insert_66677f66-c61f-11f0-86f9-525400979433', 'status':'VISIBLE', 'txnId':'34767'}

7. select a01 takes

919 rows in set (0.06 sec)

mysql> select * from a01;

What I'm doing:

#60053 has been fixed the bug resolving the cache failure issue. However, the problem still persists where the same string cache_key holds two std::shared_ptr<std::string> objects.

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 4.0
  • 3.5
  • 3.4
  • 3.3

[Copilot]

Pull Request Overview

This PR fixes a filesystem cache bug where the same cache key could have multiple std::shared_ptr<std::string> objects with custom deleters. When one shared_ptr was destroyed, it would erase the cache entry prematurely, causing performance degradation for other users of that cache entry.

Key Changes:

• Added shard_id parameter to filesystem creation functions to enable shard-specific cache key reuse
• Modified insert_fs_cache to check if the shard already has a fs_cache_key for the given cache key and reuse it if found
• Ensures only one std::shared_ptr<std::string> exists per shard-cache_key combination

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
be/src/service/staros_worker.h	Added shard_id parameter to new_shared_filesystem and insert_fs_cache method signatures
be/src/service/staros_worker.cpp	Implemented cache key reuse logic in insert_fs_cache by checking shard's existing fs_cache_key before creating a new one, and updated call sites to pass shard_id

[mergify]

backport branch-3.5

✅ Backports have been created

• #65977 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-3.5

[mergify]

backport branch-4.0

🛑 Command backport branch-4.0 cancelled because of a new backport command with different arguments

[mergify]

backport branch-3.3

🛑 Command backport branch-3.3 cancelled because of a new backport command with different arguments

[mergify]

backport branch-3.4

🛑 Command backport branch-3.4 cancelled because of a new backport command with different arguments

[kevincai]

@Mergifyio backport branch-4.0 branch-3.5 branch-3.4 branch-3.3

[mergify]

backport branch-4.0 branch-3.5 branch-3.4 branch-3.3

✅ Backports have been created

• #65978 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-4.0
• #65977 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-3.5
• #65979 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-3.4
• #65980 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-3.3

[kevincai]

@Mergifyio backport branch-4.0

[mergify]

backport branch-4.0

✅ Backports have been created

• #65978 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-4.0

[kevincai]

@Mergifyio backport branch-3.4

[kevincai]

@Mergifyio backport branch-3.3

[mergify]

backport branch-3.4

✅ Backports have been created

• #65979 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-3.4

[mergify]

backport branch-3.3

✅ Backports have been created

• #65980 [BugFix]Fix filesystem cache failure. (backport #65823) has been created for branch branch-3.3