Proposal for adding local filepath support#40
Open
little-fort wants to merge 3 commits intoStefanKert:masterfrom
Open
Proposal for adding local filepath support#40little-fort wants to merge 3 commits intoStefanKert:masterfrom
little-fort wants to merge 3 commits intoStefanKert:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #38, the code signing task is failing when adding a condition to the task. This seems to be caused by the pipeline's handling of secure file downloads, which prevents conditions from being applied successfully.
To create an alternative solution, these proposed changes would allow a user to manually configure the local filepath of the certificate that should be used for signing. This could allow a user to point to a cert store that already exists on the build machine, or to simply implement the DownloadSecureFile task separately.
Changes:
secureFileLocationandsecureFileLocalPathoptions. The idea is that the user can select whether the task should look for the cert in the Azure secure files library or a local filepath, determined by thesecureFileLocationproperty. For UI-based configuration, thesecureFileLocationoption is presented as a radio button with Azure as the default choice. The UI will also show/hide thesecureFileLocalPathandsecureFileIdcontrols based on which location is selected. This change required removing the"required": trueflag on thesecureFileIdfield, since the web page will still trigger validation even if the control is hidden.secureFileLocationinput value, conditional logic is applied to determine how theSECURE_FILE_PATHtask variable should be set. If the location was set to Azure, then the secure file will be downloaded using the same method as before. However, if the location was set to a specific filepath, then the task variable will be populated by the value configured in thesecureFileLocalPathinput. The rest of the task's logic can remain unchanged.