Fix 32-bit limitation when a file inside the zip is bigger than 2GB. #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stuk#777 which causes Bug : uncompressed data size mismatch
|
Can we expect some 3.7.2ff including this fix in the near future. This behaviour ist really nasty! Thanks in advance Jochen |
|
In the meantime, people needing this can switch to @cantoo/jszip that is aligned with the version 3.10.1 and includes that fix. We will try to maintain it our best until this is merged. |
|
Hi, can this PR get approved and merged? It appears to be a minimalist fix for a critical issue. |
jogibear9988
added a commit
to node-projects/jszip
that referenced
this pull request
Oct 9, 2025
|
I added this to my ESM fork. But this changes in this pull were not enough. After that the CRC calculation was wrong, and also comparisons to int max value. |
|
@jogibear9988 Can you document what you changed so we can reflect it to our version too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 32-bit limitation showcased at
#777
which causes
Bug : uncompressed data size mismatch
when a file inside the zip is bigger than 2GB.