Fix local terminal sftp gfvs mount; Fix ptyxis remote window size reset #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When using "Open Local Terminal" in sftp locations, the extension currently opens the local destination path (eg. /srv in case of user@host:/srv). This patch uses Gio.File to get the correct gvfs mount of the remote location. 2. When using Ptyxis as terminal, using "Open Remote Terminal" currently resets the window size of the terminal to the default value. Fixed by stripping '--new-window' from the commandline in 'run_command_in_terminal' for Ptyxis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added some minor fixes to my fork.
I'm using Arch and have not tested this extensively on other system configurations.
When using "Open Local Terminal" in sftp locations, the extension currently opens the local destination path (eg. /srv in case of user@host:/srv). This patch uses Gio.File to get the correct gvfs mount of the remote location.
When using Ptyxis as terminal, using "Open Remote Terminal" currently resets the window size of the terminal to the default value. Fixed by stripping '--new-window' from the commandline in 'run_command_in_terminal' for Ptyxis.
Cheers