Add support for warnings #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaste
requested changes
Oct 27, 2021
gorkicode
commented
Nov 17, 2021
kaste
requested changes
Nov 18, 2021
| defaults = { | ||
| 'selector': 'source.python' | ||
| } | ||
| warning_msg_regex = r'''(?x) |
There was a problem hiding this comment.
Suggested change
| warning_msg_regex = r'''(?x) | |
| warning_msg_regex = r'''(?x) | |
| warning_msg_regex = re.compile(r'''(?x) |
We want to compile exactly once because the regex is static. Doing so in __init__ would still compile per linter run. You can do this either here as a class member or just in the global scope. Anyway, after that overriding __init__ should not be needed anymore.
| self.warning_msg_regex = re.compile(self.warning_msg_regex, 0) | ||
|
|
||
| def split_match(self, match): | ||
| # mark properly the type error message |
There was a problem hiding this comment.
Remove the comment as it's clear what we're doing here. The comment is also not a sentence. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented split_match as was suggested by @kaste in #10 an issue started by YonatanAhituv