Add bates number params to AL Document#1004
Conversation
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
b2e60e8 to
41a9eb2
Compare
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
41a9eb2 to
381af8a
Compare
|
@BryceStevenWilley let me know when this is really ready to review/merge--looks like you still made recent changes |
|
I had been waiting for jhpyle/docassemble#898 to be merged, but missed that it just got cherry-picked and is already in 1.9.2. Needs some testing there, but it shouldn't have to change much. |
|
Changing to draft--update state when it's ready to merge, and we can do a major version bump if we need if this depends on a specific Docassemble release |
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
b68a7cd to
d8adfb6
Compare
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
d8adfb6 to
9bfb1a4
Compare
|
Okay, finished testing again, there were some bug fixes that didn't make it into Docassemble that I made another PR for at jhpyle/docassemble#914, but whether that's in doesn't affect this PR ( It does still require docassemble 1.9.2, so it might be worth the major version bump. |
|
Additional discovery; ALExhibitDocument will error in Docassemble 1.9.2, as it partially uses the bates numbering stuff. We're only on 1.9.1 for our prod server, so I'm going to add a fix for ALExhibitDocument (working on it right now) to this PR, and then we'll have to merge / upgrade when we upgrade to 1.9.2. |
|
Switching back to draft, since I realized that this will break all existing interviews that don't start from the beginning. |
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
2 times, most recently
from
d92f76b to
cd66bc0
Compare
Must be given to the `using` object block, and it sets a param on the ALDocumentBundle object that gets used when `as_pdf` is called. Addds defaults for all as well.
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
cd66bc0 to
a2a5643
Compare
Passes along all of the bates parameters through all of the exhibit document classes (ALExhibitDocument, ALExhibitList, ALExhibit).
BryceStevenWilley
force-pushed
the
bates_number_to_aldoc
branch
from
a2a5643 to
b2c51ed
Compare
|
Forgot to comment back here, but fixed the remaining issues that I had found with the ALDocument (mainly being able to run with previously created objects. Should be ready for a re-review. |
2 participants
Lets the ALDocumentBundle use
bates_numberfunction when generating a PDF, as well as the work-in-progress params.Depends on jhpyle/docassemble#898