Skip to content

Resolve bug with logging multiple emails #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nonprofittechy merged 3 commits into from
Feb 24, 2026
Merged

Resolve bug with logging multiple emails #1014

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11d5f2c
Fix #1000 - bug with logging multiple emails
LemmaLegal Feb 22, 2026
71b47b8
Merge branch 'main' into 1000-concatenation-error
nonprofittechy Feb 23, 2026
9a4f65e
PR feedback - use fstrings instead of intermediate var
LemmaLegal Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions docassemble/AssemblyLine/data/questions/al_document.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,17 @@ code: |
key=action_argument("key"),
preferred_formats=preferred_formats,
)
email_arg = action_argument('email')
if isinstance(email_arg, list):
email_str = ', '.join(email_arg)
else:
email_str = str(email_arg)
if email_success:
# Exact phrase below is in Docassemble's words dictionary
log(word("E-mail was sent to") + " " + action_argument("email"), "success")
log(f" {word('E-mail was sent to')} {email_str}", "success")
else:
# E-mail failed is not in the default Docassemble words dictionary
log(word("E-mail failed"), "error")
log(f" {word('E-mail failed')} to {email_str}", "error")
---
generic object: ALDocumentBundle
event: x.send_email_to_action_event
Expand Down Expand Up @@ -67,10 +72,15 @@ code: |
key=action_argument("key"),
preferred_formats=preferred_formats,
)
email_arg = action_argument('email')
if isinstance(email_arg, list):
email_str = ', '.join(email_arg)
else:
email_str = str(email_arg)
if email_success:
log("Email sent to " + action_argument("email")) # to log file
log(f"Email sent to {email_str}") # to log file
else:
log(word("E-mail failed to ") + action_argument("email"))
log(f" {word('E-mail failed to ')} {email_str}")

json_response({"success": email_success})
---
Expand Down Expand Up @@ -208,4 +218,4 @@ subquestion: |
<span class="sr-only visually-hidden">Generating preview...</span>
</div>
event: al_preview_waiting_screen
reload: True
reload: True
Loading