feat(routing): Migrate routing processor to connector for metrics collection #4025
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dhruv-shah-sumo
changed the title
dhruv-shah-sumo
force-pushed
the
dhruv/metric-routingc-connector
branch
from
23298c4 to
c88ce92
Compare
dhruv-shah-sumo
changed the title
dhruv-shah-sumo
force-pushed
the
dhruv/metric-routingc-connector
branch
4 times, most recently
from
dca7728 to
cbaa141
Compare
There was a problem hiding this comment.
@dhruv-shah-sumo its a good idea for this to be its own PR - lets add a changelog for this. I think this migration should be called out as a feature instead of chore, because it makes non-trivial changes to the otel configuration. This is also currently a breaking change, but it doesn't need to be.
| - metrics/sumologic/default | ||
| table: | ||
| - pipelines: | ||
| - metrics/apiserver |
There was a problem hiding this comment.
Could we add an additional exporter in the input table and verify that it shows up in the table here?
There was a problem hiding this comment.
could also put the output in the description ^^ or a jira, so in the future, someone has more visual context
There was a problem hiding this comment.
Could we add an additional exporter in the input table and verify that it shows up in the table here?
metrics routing does not expose options to add custom exporters but logs do. To increase the testing, I have enabled debug exporter so that you can see the metrics/debug pipeline being created & added to the expected output routing.
There was a problem hiding this comment.
could also put the output in the description ^^ or a jira, so in the future, someone has more visual context
@chan-tim-sumo Do you mean the after/before config changes for this migration?
There was a problem hiding this comment.
after config changes (i assume before and after SHOULD be the same anyways)
There was a problem hiding this comment.
@chan-tim-sumo No, they will be different. I'll put both.
| ## ## see routing processor documentation for more details: | ||
| ## ## https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/aee4b75100530bce7edbf736fbcf76ac4f6ced6d/processor/routingprocessor/README.md#tech-preview-opentelemetry-transformation-language-statements-as-routing-conditions | ||
| ## ## exporters is an array of the exporter | ||
| ## exporters: |
There was a problem hiding this comment.
this is a breaking change and is not necessary see - https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/4012/files#r2481804958
| }, | ||
| otelConfig.Service.Pipelines.Metrics.Exporters, | ||
| ) | ||
| assert.Contains(t, otelConfig.Connectors, "routing/default") |
There was a problem hiding this comment.
Should there be an assertion here to ensure all the expected pipelines are present?
rnishtala-sumo
changed the title
dhruv-shah-sumo
force-pushed
the
dhruv/metric-routingc-connector
branch
3 times, most recently
from
35485f2 to
a329478
Compare
dhruv-shah-sumo
force-pushed
the
dhruv/metric-routingc-connector
branch
4 times, most recently
from
bad9697 to
90e9288
Compare
…cs collection Usage of routing connector is feature flagged and will be kept off/false by default. After sufficient notices and release notes, the feature flag to use routing connector in metrics collection will be turned on. Routing processor is currently removed from the otelcol-contrib version upstream, but to handle the migration better, sumo is still keeping routing processor in its version of otel col. Signed-off-by: Dhruv Shah <[email protected]>
dhruv-shah-sumo
force-pushed
the
dhruv/metric-routingc-connector
branch
from
90e9288 to
83f3b0a
Compare
0.136.* version of otel collector does not support routing processor, the routing processor is being moved to routing connector. This PR changes the routing config for metrics.
OSC-1217
Checklist