Skip to content

SUMO-211128: Replaced S3 bucket name to fix security issue #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himanshu219 merged 1 commit into from
Feb 13, 2025
Merged

SUMO-211128: Replaced S3 bucket name to fix security issue #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/aws_cloudtrail.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module "sumologic-cloudtrail-apps" {
"description" = "This source is ceated a.",
"bucket_details" = {
"create_bucket" = false,
"bucket_name" = "sumologic-aws-observability-templates",
"bucket_name" = "YourS3BucketName",
"path_expression" = "AWSLogs/*/CloudTrail/us-east-1/*",
"force_destroy_bucket" = true
},
Expand Down
12 changes: 6 additions & 6 deletions terratest/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function set_env_variables()
local type="$1"
if [[ "${type}" = *"cloudtrail"* ]];then
echo "Setting env variables for ${type}"
export BUCKET_NAME="sumologic-aws-observability-templates"
export BUCKET_NAME="<YourS3BucketName>"
export PATH_EXPRESSION="AWSLogs/<AWS_ACCOUNT_ID>/CloudTrail/us-east-1/*"
export IAM_ROLE="arn:aws:iam::<AWS_ACCOUNT_ID>:role/TestingTerraformCloudTrailRole"
export TOPIC_ARN="arn:aws:sns:us-east-1:<AWS_ACCOUNT_ID>:dynamodb"
Expand All @@ -72,21 +72,21 @@ function set_env_variables()
export COLLECTOR_ID="<COLLECTOR_ID>"
elif [[ "${type}" = *"elb"* ]];then
echo "Setting env variables for ${type}"
export BUCKET_NAME_US_WEST_1="cf-templates-1qpf3unpuo1hw-us-west-1"
export BUCKET_NAME_US_WEST_1="<YourS3BucketName>-us-west-1"
export PATH_EXPRESSION_US_WEST_1="*AWSLogs/<AWS_ACCOUNT_ID>/elasticloadbalancing/us-west-1/*"
export TOPIC_ARN_US_WEST_1="arn:aws:sns:us-west-1:<AWS_ACCOUNT_ID>:dynamodb"
export BUCKET_NAME_AP_SOUTH_1="cf-templates-1qpf3unpuo1hw-ap-south-1"
export BUCKET_NAME_AP_SOUTH_1="<YourS3BucketName>-ap-south-1"
export PATH_EXPRESSION_AP_SOUTH_1="*AWSLogs/<AWS_ACCOUNT_ID>/elasticloadbalancing/ap-south-1/*"
export IAM_ROLE="arn:aws:iam::<AWS_ACCOUNT_ID>:role/TestingTerraformCloudTrailRole"
export COLLECTOR_ID="<COLLECTOR_ID>"
elif [[ "${type}" = *"kinesisfirehoseforlogs"* ]];then
echo "Setting env variables for ${type}"
export BUCKET_NAME_US_WEST_1="cf-templates-1qpf3unpuo1hw-us-west-1"
export BUCKET_NAME_US_WEST_1="<YourS3BucketName>-us-west-1"
export COLLECTOR_ID="<COLLECTOR_ID>"
elif [[ "${type}" = *"kinesisfirehoseformetrics"* ]];then
echo "Setting env variables for ${type}"
export BUCKET_NAME_US_WEST_1="cf-templates-1qpf3unpuo1hw-us-west-1"
export BUCKET_NAME_AP_SOUTH_1="cf-templates-1qpf3unpuo1hw-ap-south-1"
export BUCKET_NAME_US_WEST_1="<YourS3BucketName>-us-west-1"
export BUCKET_NAME_AP_SOUTH_1="<YourS3BucketName>-ap-south-1"
export IAM_ROLE="arn:aws:iam::<AWS_ACCOUNT_ID>:role/TestingTerraformCloudTrailRole"
export COLLECTOR_ID="<COLLECTOR_ID>"
elif [[ "${type}" = *"rootcause"* ]];then
Expand Down
Loading