ENH: Add Active Registration Model metrics#450
Open
kaspermarstal wants to merge 2 commits intomainfrom
Open
Conversation
Kasper Marstal and Stefan Klein "Active registration models", Proc. SPIE 10133, Medical Imaging 2017: Image Processing, 101330Y (24 February 2017); https://doi.org/10.1117/12.2254356)
Member
Author
|
Mhm, I disabled the metrics by default because of the external dependency on boost. Seems like it still tries to find boost even though the metrics are disabled. Will fix this. |
N-Dekker
reviewed
Apr 1, 2021
| } | ||
|
|
||
| template <class F> | ||
| typename boost::result_of<F()>::type callstatismoImpl(F f) const { |
Member
There was a problem hiding this comment.
Maybe decltype(F()), instead of boost::result_of?
N-Dekker
reviewed
Apr 2, 2021
| float noiseVariance, | ||
| double modelVarianceRetained | ||
| ) { | ||
| statismo::StatisticalModel<Representer>* model_statismo = callstatismoImpl(boost::bind(&ImplType::BuildNewModel, this->m_impl, SampleDataStructureList, surrogateTypes, conditioningInfo, noiseVariance, modelVarianceRetained)); |
Member
There was a problem hiding this comment.
Instead of boost::bind, maybe use std::bind...?
N-Dekker
reviewed
Apr 2, 2021
| typedef MeshType DatasetType; | ||
|
|
||
| // An unordered map is used to cache pointid for corresonding points | ||
| typedef boost::unordered_map<PointType, unsigned> PointCacheType; |
Member
There was a problem hiding this comment.
Instead of boost::unordered_map, maybe use std::unordered_map...?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an intensity penalty metric and a shape penalty metric inspired by Active Appearance Models. The metrics are disabled by default.
Kasper Marstal and Stefan Klein "Active registration models", Proc. SPIE 10133, Medical Imaging 2017: Image Processing, 101330Y (24 February 2017); https://doi.org/10.1117/12.2254356).