Skip to content

Conversation

@lucaboesch
Copy link

The spacing between the displayed elements does not really work and leads to a poorly formatted text.
Here's a fix which puts in space   entities. I tried it with spaces and line breaks beforehand, but this is the only working solution I could come up with.

wordscountspace

@Tamir5ht
Copy link

Hi @lucaboesch,
Thanks for the help, the "Words count" need to be sr-only and not be shown.
I've put &#160 between the Words and the counter so it we look clean and fix button.js that he will not show sr-only

@Menrath
Copy link

Menrath commented Feb 9, 2022

The current behat tests fail with this modifications.

@lucaboesch lucaboesch force-pushed the wordspacing branch 2 times, most recently from 9862f29 to 2b62391 Compare February 9, 2022 15:28
@lucaboesch
Copy link
Author

Tests do pass again.
Note that is is not possible to check for a whitespace at the end of an element.
We are in a situation here in which Behat has to check<div class="[d-inline-flex p-0]()"><strong>Words:&nbsp;</strong><span id="[id_description_editor-word-count]()">0</span> but trims the trailing whitespace in an element.
Believe me I've tried &nbsp:, \xc2\xa0, \U0a0 and other.

@Menrath
Copy link

Menrath commented Feb 10, 2022

@lucaboesch I had the same issue and in my Pull-Request I decided for generating the space with CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants