-
Notifications
You must be signed in to change notification settings - Fork 258
Fix inconsistent pip package name that breaks pip install
of requirements.txt
#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ multi_line_output=3 | |
include_trailing_comma=True | ||
known_standard_library=numpy,setuptools | ||
skip_glob=*/__init__.py | ||
known_myself=segment_anything | ||
known_myself=segment_anything_hq | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This bit of configuration isn't crucial - it only relates to |
||
known_third_party=matplotlib,cv2,torch,torchvision,pycocotools,onnx,black,isort | ||
no_lines_before=STDLIB,THIRDPARTY | ||
sections=FUTURE,STDLIB,THIRDPARTY,MYSELF,FIRSTPARTY,LOCALFOLDER | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ | |
from setuptools import find_packages, setup | ||
|
||
setup( | ||
name="segment_anything", | ||
name="segment_anything_hq", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this is the crucial fix for the "Generating metadata for package segment-anything-hq produced metadata for project name segment-anything" error - here, we're correcting the Distribution Package name as used by See also pypa/pipenv#5445 (comment) |
||
version="1.0", | ||
install_requires=[], | ||
packages=find_packages(exclude="notebooks"), | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we're updating the Import Package in this example to match the name given in the HQ-SAM documentation:
sam-hq/README.md
Line 90 in 5fd027e
Note that in order for this to work, we need to rename the
/segment-anything/
folder to/segment-anything-hq/
(which in Git, means a lot of files get their paths renamed).