Beta/biome fix

biome.json

@@ -24,9 +24,8 @@
       "complexity": {
         "noVoid": "error"
       },
-
       "correctness": {
-        "useExhaustiveDependencies": "off",
+        "useExhaustiveDependencies": "info",
         "noUndeclaredVariables": "error",
         "useJsxKeyInIterable": "error"
       },

src/components/alerts/AlertsPage.tsx

@@ -18,7 +18,7 @@ export default function TtcAlertList() {
     (_event: SelectTabEvent, data: SelectTabData) => {
       setEnabledTab(data.value);
     },
-    [enabledTab]
+    []
   );
   const currentDate = new Date().toISOString().split("T")[0];
   // get saturday's date

src/components/alerts/bsky-alerts/AllBskyAlerts.tsx

@@ -41,7 +41,7 @@ export const AllBskyAlerts = () => {
     (_event: SelectTabEvent, data: SelectTabData) => {
       setEnabledTab(data.value as string);
     },
-    [enabledTab]
+    []
   );
 
   const lastSkeetTime = useMemo(() => {
@@ -110,7 +110,7 @@ export const AllBskyAlerts = () => {
         setTimeframe(option);
       }
     },
-    [timeframe]
+    []
   );
 
   return (

src/components/alerts/subway-closures/SubwayClosures.tsx

@@ -1,5 +1,5 @@
 import { useQuery } from "@tanstack/react-query";
-import { useMemo } from "react";
+import { useCallback, useMemo } from "react";
 
 import {
   fetchSubwayClosure,
@@ -20,19 +20,22 @@ export const SubwayClosures = ({ startDate }: { startDate: string }) => {
     return "Subway Closures";
   }, [startDate, currentDate]);
 
-  const getClosuresByDateMatch = (match: boolean) =>
-    subwayClosureQuery.data?.filter(
-      (closure) => (closure.last_shown === currentDate) === match
-    ) ?? [];
+  const getClosuresByDateMatch = useCallback(
+    (match: boolean) =>
+      subwayClosureQuery.data?.filter(
+        (closure) => (closure.last_shown === currentDate) === match
+      ) ?? [],
+    [subwayClosureQuery.data, currentDate]
+  );
 
   const listedSubwayClosures = useMemo(
     () => getClosuresByDateMatch(true),
-    [subwayClosureQuery, currentDate]
+    [getClosuresByDateMatch]
   );
 
   const unlistedSubwayClosures = useMemo(
     () => getClosuresByDateMatch(false),
-    [subwayClosureQuery, currentDate]
+    [getClosuresByDateMatch]
   );
 
   if (!subwayClosureQuery.isFetched) {

src/components/bookmarks/Bookmark.tsx

@@ -30,7 +30,7 @@ export default function Bookmark() {
 
   const clearAllBookmarks = useCallback(() => {
     dispatch(clearStopBookmarks());
-  }, []);
+  }, [dispatch]);
 
   return (
     <article className="bookmark-container">

src/components/bookmarks/BookmarkCard.tsx

@@ -15,7 +15,7 @@ export function BookmarkCard(props: { id: number }) {
 
   const checkBookmarkStatus = useCallback(() => {
     dispatch(removeStopBookmark(props.id));
-  }, [stopBookmarks.ids]);
+  }, [dispatch, props.id]);
 
   const item = stopBookmarks.entities[id];
 

src/components/countdown/CountdownSec.tsx

@@ -32,7 +32,7 @@ export function CountdownSec(props: {
     }
     // Cleanup
     return () => clearTimeout(timer);
-  }, [sec]);
+  }, [epochTime, sec, props.epochTime]);
   return (
     <div className={style["countdown-sec"]}>
       {(sec < 180 || props.index === 0) && (

src/components/display/VehicleLocation.tsx

@@ -37,7 +37,7 @@ export default function VehicleLocation(props: {
       const center = fromLonLat([data.vehicle?.lon, data.vehicle?.lat]);
       setView({ center, zoom: 16 });
     }
-  }, []);
+  }, [props.data?.Error, data.vehicle]);
 
   if (error) {
     return (

src/components/etaCard/EtaCard.tsx

@@ -10,7 +10,7 @@ import {
   DialogTrigger,
 } from "@fluentui/react-components";
 import { Dismiss12Filled, Edit12Filled } from "@fluentui/react-icons";
-import { useCallback } from "react";
+import { useCallback, useMemo } from "react";
 import { useTranslation } from "react-i18next";
 import { Link } from "react-router";
 
@@ -32,7 +32,9 @@ export function EtaCard(props: {
   enabled?: string[];
   direction?: string;
 }) {
-  const uniqueLines = [...new Set(props.lines)];
+  const uniqueLines = useMemo(() => {
+    return [...new Set(props.lines)];
+  }, [props.lines]);
   const directionArray = props.direction?.split(", ") ?? [];
   return (
     <li
@@ -123,8 +125,9 @@ function FavouriteEditor(props: {
   enabled?: string[];
   onDelete?: () => void;
 }) {
-  const uniqueLines = [...new Set(props.lines)];
-
+  const uniqueLines = useMemo(() => {
+    return [...new Set(props.lines)];
+  }, [props.lines]);
   const { t } = useTranslation();
 
   const dispatch = useAppDispatch();
@@ -171,7 +174,7 @@ function FavouriteEditor(props: {
         }
       }
     },
-    [uniqueLines, props.enabled]
+    [uniqueLines, props.enabled, dispatch, props.id]
   );
 
   return (
@@ -207,7 +210,7 @@ function LineCheckbox(props: {
 }) {
   const handleClick = useCallback(() => {
     props.onChangeFunction(props.line);
-  }, [props.enabled]);
+  }, [props.onChangeFunction, props.line]);
   return (
     <Checkbox
       key={props.id + props.line}

src/components/fetch/FetchLineStop.tsx

@@ -38,7 +38,7 @@ function LineStopPredictionInfo(props: {
 
   const fetchPredictionClick = useCallback(() => {
     setLastUpdatedAt(Date.now());
-  }, [lastUpdatedAt]);
+  }, []);
 
   if (data) {
     if (data.Error) {

src/components/fetch/FetchRoute.tsx

@@ -64,11 +64,11 @@ function RouteInfo(props: { line: number }): JSX.Element {
 
   const handleFetchBusClick = useCallback(() => {
     setLastUpdatedAt(Date.now());
-  }, [lastUpdatedAt]);
+  }, []);
 
   const handleDirClick = useCallback(
     (_event: SelectTabEvent, data: SelectTabData) => setEnabledDir(data.value),
-    [enabledDir]
+    []
   );
 
   if (ttcRouteResponse.data) {

src/components/fetch/FetchSubwayRoute.tsx

@@ -83,11 +83,11 @@ function RouteInfo(props: { line: number }): JSX.Element {
     return () => {
       controller.abort();
     };
-  }, [lastUpdatedAt, ttcSubwayLineResponse.data]);
+  }, [ttcSubwayLineResponse.data, dispatch, lineNum]);
 
   const handleFetchBusClick = useCallback(() => {
     setLastUpdatedAt(Date.now());
-  }, [lastUpdatedAt]);
+  }, []);
 
   if (ttcSubwayLineResponse.data) {
     const data = ttcSubwayLineResponse.data;

src/components/fetch/FetchSubwayStop.tsx

@@ -31,11 +31,11 @@ function SubwayStopPredictionInfo(props: {
 
   const fetchPredictions = useCallback(() => {
     setLastUpdatedAt(Date.now());
-  }, [lastUpdatedAt]);
+  }, []);
 
   const fetchPredictionClick = useCallback(() => {
     fetchPredictions();
-  }, []);
+  }, [fetchPredictions]);
 
   const stationInfo = subwayDbSelectors.selectById(
     store.getState().subwayDb,
@@ -58,7 +58,7 @@ function SubwayStopPredictionInfo(props: {
         );
       });
     },
-    [data?.nextTrains]
+    [data?.nextTrains, t]
   );
 
   if (!data) {

src/components/fetch/queries.ts

@@ -245,7 +245,7 @@ export const atprotoTtcAlerts = queryOptions<FeedViewPost[]>({
 });
 
 export const getYrtStops = queryOptions<
-  { stopId: string; stopPublicId: string }[]
+  { stopId: string; stopPublicId: string; name: string }[]
 >({
   queryKey: ["yrt-stops"],
   queryFn: async () => {

src/components/nav/BaseBarComponents.tsx

@@ -54,7 +54,7 @@ export function BaseBarComponents({ width }: { width: number }) {
       default:
         return fluentStyle.smallRoundNavButton;
     }
-  }, [width]);
+  }, [width, fluentStyle]);
 
   const baseBarComponents = navItems.map((item) => {
     return (

src/components/nearby/Nearby.tsx

@@ -81,13 +81,13 @@ export default function Nearby() {
         setIsLoadingLocation(false);
       });
     }
-  }, []);
+  }, [handleRefresh]);
 
   useEffect(() => {
     if (locationMode) {
       handleGeolocation();
     }
-  }, []);
+  }, [locationMode, handleGeolocation]);
 
   const locationModeChange = useCallback(
     (ev: {
@@ -103,7 +103,7 @@ export default function Nearby() {
         })
       );
     },
-    [setLocationMode]
+    [dispatch]
   );
 
   return (

src/components/nearby/NearbyList.tsx

@@ -37,7 +37,7 @@ export default function NearbyList(props: {
         ),
       };
     });
-  }, [stopsList, props.coordinate]);
+  }, [subwayStops, props.coordinate]);
 
   const busAndSubwayStops = useMemo(() => {
     if (!stopsList.length) {

src/components/nearby/NearbyStopCard.tsx

@@ -40,7 +40,7 @@ export default function NearbyStopCard({ stop }: { stop: StopWithDistance }) {
       return templist.sort((a, b) => a.epochTime - b.epochTime);
     }
     return [];
-  }, [getStopPredictionsResponse.data]);
+  }, [stop.type, getStopPredictionsResponse.data]);
 
   const lines = useMemo(() => {
     if (stop.type === "ttc-subway") {
@@ -67,7 +67,7 @@ export default function NearbyStopCard({ stop }: { stop: StopWithDistance }) {
       return undefined;
     }
     return stop.directions;
-  }, [stop, getStopPredictionsResponse.data]);
+  }, [stop]);
 
   return (
     <EtaCard

src/components/rawDisplay/RawDisplay.tsx

@@ -43,15 +43,13 @@ export default function RawDisplay(props: {
   const fluentStyle = fluentStyles();
   const { t } = useTranslation();
 
-  const settings = settingsSelectors.selectAll(store.getState().settings);
-
   const devModeValue = settingsSelectors.selectById(
     store.getState().settings,
     "devMode"
   );
   const isInDevMode = useMemo(
     () => (devModeValue ? devModeValue.value === "true" : false),
-    [settings]
+    [devModeValue]
   );
 
   const rawDisplay = (

src/components/settings/Settings.tsx

@@ -54,7 +54,7 @@ export function Settings() {
     (_: FormEvent<HTMLDivElement>, data: { value?: string }) => {
       i18n.changeLanguage(data.value);
     },
-    []
+    [i18n.changeLanguage]
   );
 
   const handleUnifiedEtaChange = useCallback(
@@ -68,7 +68,7 @@ export function Settings() {
         })
       );
     },
-    [setUnifiedEta]
+    [dispatch]
   );
 
   const devModeChange = useCallback(
@@ -85,7 +85,7 @@ export function Settings() {
         })
       );
     },
-    [setDevMode]
+    [dispatch]
   );
 
   // Temp. search box
@@ -105,7 +105,7 @@ export function Settings() {
         navigate(`../yrt/stops/${stopInput}`);
       }
     }
-  }, [stopInput]);
+  }, [stopInput, navigate]);
 
   return (
     <main className={style["settings-page"]}>

src/routes/Home.tsx

@@ -45,7 +45,7 @@ export default function Home() {
         })
       );
     },
-    [enabledTab]
+    [dispatch]
   );
   return (
     <main className="home-page">

src/routes/RelativeVehiclePosition.tsx

@@ -29,7 +29,7 @@ export default function RelativeVehiclePosition() {
 
   const onRefreshClick = useCallback(() => {
     setLastUpdatedAt(Date.now());
-  }, [lastUpdatedAt]);
+  }, []);
 
   return (
     <main className={styles["relative-vehicle-position"]}>
@@ -55,7 +55,7 @@ function RefreshButton({ onClick }: { onClick: () => void }) {
 
   const useOnClick = useCallback(() => {
     onClick();
-  }, []);
+  }, [onClick]);
 
   return (
     <Button onClick={useOnClick} icon={<ArrowClockwise24Regular />}>

src/routes/Search.tsx

@@ -20,7 +20,7 @@ export default function SearchElement() {
     if (lineInput !== "") {
       navigate(`lines/${lineInput}`);
     }
-  }, [lineInput]);
+  }, [lineInput, navigate]);
 
   return (
     <div className="search-form">