Skip to content

Refactor CodeQL workflow configuration#329

Merged
gkuznik merged 3 commits intomasterfrom
CommanderStorm-patch-1
Mar 6, 2026
Merged

Refactor CodeQL workflow configuration#329
gkuznik merged 3 commits intomasterfrom
CommanderStorm-patch-1

Conversation

@CommanderStorm
Copy link
Member

Updated workflow name to 'CodeQL' and removed comments.

Updated workflow name to 'CodeQL' and removed comments.
Copilot AI review requested due to automatic review settings March 6, 2026 17:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds/updates the repository’s GitHub Actions CodeQL workflow configuration to run CodeQL analysis on pushes/PRs to master and on a weekly schedule.

Changes:

  • Introduces a CodeQL workflow with a language matrix (actions, python) and CodeQL init/analyze steps.
  • Configures workflow triggers for push, pull_request, and a scheduled cron run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +33 to +38
build-mode: none
# CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'rust', 'swift'
# Use `c-cpp` to analyze code written in C, C++ or both
# Use 'java-kotlin' to analyze code written in Java, Kotlin or both
# Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both
# To learn more about changing the languages that are analyzed or customizing the build mode for your analysis,
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strategy.matrix.include is a YAML sequence but the list items are not indented under include:. As written, the workflow YAML will not parse; indent the - language: ... entries so they are children of include: (and keep build-mode aligned under each item).

Copilot uses AI. Check for mistakes.
Comment on lines +47 to +50
# This includes steps like installing compilers or runtimes (`actions/setup-node`
# or others). This is typically only required for manual builds.
# - name: Setup runtime (example)
# uses: actions/setup-example@v1
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps: key is followed by - name: ... entries at the same indentation level as steps:. In GitHub Actions YAML, step items must be indented beneath steps:; otherwise the workflow file is invalid and the job will fail to load.

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +18
name: Analyze (${{ matrix.language }})
runs-on: ubuntu-latest
permissions:
# required for all workflows
security-events: write

Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR description says comments were removed, but this workflow still contains extensive commented guidance (e.g., runner sizing, setup steps, query packs). Either update the description to match, or remove the remaining comments if that is the intent.

Copilot uses AI. Check for mistakes.
Comment on lines +48 to +49
# or others). This is typically only required for manual builds.
# - name: Setup runtime (example)
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other workflows in this repo use actions/checkout@v5 (e.g., .github/workflows/ci.yml, publish.yml, swagger.yml), but this workflow pins actions/checkout@v4. Consider aligning versions across workflows to reduce maintenance and keep consistent action behavior.

Copilot uses AI. Check for mistakes.
@gkuznik gkuznik merged commit 4ad60d4 into master Mar 6, 2026
5 checks passed
@gkuznik gkuznik deleted the CommanderStorm-patch-1 branch March 6, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants