feature/define cafe order system by Gangsss · Pull Request #12 · Team-CLUE/headfirst_design_pattern

Gangsss · 2022-07-31T12:20:37Z

Changes?

데코레이터 패턴을 위한 코드 추가

Why we need?

데코레이터 패턴 학습

Test?

cafe_order_test.py를 통해 테스트

Checklist

Assignees updated the README, if necessary.
Assignees checked the runnability of the code.
Reviewers checked the runnability of the code.

Anything Else? (Optional)

없음

…pattern into feature/cafe_order_system

Kimdongui · 2022-09-19T13:40:05Z

src/cafeordersimulator/beverage.py

+        다양한 Beverage들을 구현하기 위한 Abstractive class
+    """
+
+    def getdescription(self) -> str:


Suggested change

def getdescription(self) -> str:

def get_description(self) -> str:

으로 끊어주면 어떨까요?

넵 피드백 감사합니다

Kimdongui · 2022-09-19T13:42:12Z

src/cafeordersimulator/beverage.py

+
+        Args:
+            None
+
+        Returns:
+            None
+        """


input이나 return이 없는 경우, 작성하지 않는 것을 표준으로 하겠습니다!

넵 확인했습니다 다음 커밋 시 반영하겠습니다.

Kimdongui · 2022-09-19T13:42:27Z

src/cafeordersimulator/beverage.py

+
+
+class HouseBlend(Beverage):
+    """summary


summary 단어 제거 부탁합니다!

넵 알겠습니다!

Gangsss · 2022-09-21T02:01:47Z

Thx for your comment @Kimdongui

Co-authored-by: Kim dong hyun, 김동현 <rkdqus2006@naver.com>

surfing2003 · 2022-09-26T12:04:46Z

src/cafeordersimulator/condiment.py

+            Args:
+                None


이부분 제거되어도 좋을듯합니다!

surfing2003 · 2022-09-26T13:11:53Z

src/cafeordersimulator/condiment.py

+        if self._beverage.get_size() == "tall":
+            beverage_cost += 0.10
+        elif self._beverage.get_size() == "grande":
+            beverage_cost += 0.15
+        elif self._beverage.get_size() == "venti":
+            beverage_cost += 0.20


이부분 딕셔너리를 활용하는 건 별로일까요..?

Kimdongui · 2022-09-26T13:19:19Z

src/cafeordersimulator/condiment.py

+            설명을 덧붙이는 함수
+
+        Returns:
+            beverage의 이름 + ", 모카"


type도 같이 명시 하면 좋을 것 같습니다!

Kimdongui · 2022-09-26T13:23:08Z

src/cafeordersimulator/test.py

+
+
+def main() -> None:
+    """summary


jonhyuk0922 · 2022-09-26T13:16:17Z

src/cafeordersimulator/beverage.py

+from abc import ABCMeta, abstractmethod
+
+
+class Beverage(metaclass=ABCMeta):


https://docs.python.org/ko/3/library/abc.html
: abstractmethod 이 데코레이터를 사용하려면 클래스의 메타 클래스가 [ABCMeta]이거나 여기에서 파생된 것이어야 합니다.

라고 공식문서에 적혀있습니다.

jonhyuk0922 · 2022-09-26T13:17:21Z

src/cafeordersimulator/beverage.py

+    def __init__(self):
+        self.size = "tall"
+
+    def get_description(self) -> str:


경현 said : 해당 메서드도 abstractmethod 데코레이터가 필요할 것 같습니다.

jonhyuk0922 · 2022-09-26T13:21:35Z

src/cafeordersimulator/condiment.py

+        self._beverage = bevarage
+
+    @property
+    def beverage(self) -> Beverage:


추상클래스에서 property 나 abstractmethod 데코레이터로 감싸진 메서드는 재정의되야 인스턴스를 생성할 수 있다고 알고있는데, CondimentDecorator를 상속받은 Mocha에서 beverage를 재정의안해주는데 인스턴스가 생성될까요?

https://docs.python.org/ko/3/library/abc.html

검색 키워드 : 프로퍼티

KyungHyunLim · 2022-09-19T13:35:42Z

src/cafeordersimulator/beverage.py

+    Description:
+        다양한 Beverage들을 구현하기 위한 Abstractive class
+    """
+


get_description은 abstract 메소드가 안붙어있는 이유가 있나요?

KyungHyunLim · 2022-09-26T13:26:28Z

src/cafeordersimulator/condiment.py

+        Description:
+            cost 계산시 size에 따라서 cost를 계산해준다.
+        Returns:
+            beverage cost + size depends cost


Description과 Returns 사이에 공백 있고 없고 통일하면 좋을 것 같습니다.

Kimdongui · 2022-09-26T13:30:58Z

test.py 를 tests/ 디렉토리 밑으로 옮겨주세요!

featue/define beverage class

8a06af1

github-actions bot added the size/L 110+ lines are updated label Jul 31, 2022

github-actions bot assigned Gangsss Jul 31, 2022

github-actions bot requested review from Kimdongui, KyungHyunLim, jonhyuk0922 and surfing2003 July 31, 2022 12:20

github-actions bot added the feature Some features are implemented label Jul 31, 2022

Gangsss changed the title ~~featue/define beverage class~~ feature/define cafe order system Jul 31, 2022

Gangsss removed request for Kimdongui, KyungHyunLim, jonhyuk0922 and surfing2003 July 31, 2022 12:42

Gangsss marked this pull request as draft July 31, 2022 12:42

Gangsss added 4 commits August 29, 2022 18:00

✨ add condiment python script

faf3d9b

Merge branch 'main' of https://github.com/Team-CLUE/headfirst_design_…

eb71be2

…pattern into feature/cafe_order_system

Merge branch 'main' of https://github.com/Team-CLUE/headfirst_design_…

170f291

…pattern into feature/cafe_order_system

✨ fix test script

91004ff

Kimdongui reviewed Sep 19, 2022

View reviewed changes

Gangsss and others added 3 commits September 26, 2022 14:16

update function name

458949d

Co-authored-by: Kim dong hyun, 김동현 <rkdqus2006@naver.com>

✨ fix function name

a962395

✨ fix function name and description

22a02cb

Gangsss requested a review from Kimdongui September 26, 2022 08:56

Gangsss added 3 commits September 26, 2022 20:42

✨ add size function

1a2eadd

✨ fix description

df79f7c

✨ add test

c3006ad

Gangsss marked this pull request as ready for review September 26, 2022 11:58

Gangsss requested a review from KyungHyunLim September 26, 2022 12:15

jonhyuk0922 self-requested a review September 26, 2022 13:14

surfing2003 reviewed Sep 26, 2022

View reviewed changes

Kimdongui reviewed Sep 26, 2022

View reviewed changes

jonhyuk0922 approved these changes Sep 26, 2022

View reviewed changes

KyungHyunLim reviewed Sep 26, 2022

View reviewed changes

	def getdescription(self) -> str:
	def get_description(self) -> str:

		from abc import ABCMeta, abstractmethod


		class Beverage(metaclass=ABCMeta):

Conversation

Gangsss commented Jul 31, 2022

Changes?

Why we need?

Test?

Checklist

Anything Else? (Optional)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gangsss commented Sep 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonhyuk0922 Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonhyuk0922 Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonhyuk0922 Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KyungHyunLim Sep 19, 2022 • edited by Kimdongui Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kimdongui commented Sep 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jonhyuk0922 Sep 26, 2022 •

edited

Loading

jonhyuk0922 Sep 26, 2022 •

edited

Loading

jonhyuk0922 Sep 26, 2022 •

edited

Loading

KyungHyunLim Sep 19, 2022 •

edited by Kimdongui

Loading