-
Notifications
You must be signed in to change notification settings - Fork 0
๐ :: (#419) nullable ์ฒ๋ฆฌ #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "feature/419-nullable-\uCC98\uB9AC"
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -253,10 +253,16 @@ private fun RecruitmentDetailInfo( | |||||||||||||||||||||||||||
| title = stringResource(id = R.string.etc), | ||||||||||||||||||||||||||||
| content = etc, | ||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||
| if (winterIntern) { | ||||||||||||||||||||||||||||
| if (winterIntern && integrationPlan != null) { | ||||||||||||||||||||||||||||
| Detail( | ||||||||||||||||||||||||||||
| title = stringResource(id = R.string.integration_plan), | ||||||||||||||||||||||||||||
| content = "${if (integrationPlan) "์" else "์"}์", | ||||||||||||||||||||||||||||
| content = "${if (integrationPlan!!) "์" else "์"}์", | ||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
Comment on lines
+256
to
+261
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ๐ ๏ธ Refactor suggestion !! ์ฐ์ฐ์ ์ฌ์ฉ์ ๋ํ ์์ ์ฑ ๊ฐ์ ํ์
๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ์ ์ํฉ๋๋ค: if (winterIntern && integrationPlan != null) {
Detail(
title = stringResource(id = R.string.integration_plan),
- content = "${if (integrationPlan!!) "์" else "์"}์",
+ content = "${if (integrationPlan) "์" else "์"}์",
)
}๐ Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||
| if(!winterIntern && hireConvertible != null) { | ||||||||||||||||||||||||||||
| Detail( | ||||||||||||||||||||||||||||
| title = stringResource(id = R.string.hireConvertible), | ||||||||||||||||||||||||||||
| content = "${if (hireConvertible!!) "์" else "์"}์", | ||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
| if(!winterIntern && hireConvertible != null) { | |
| Detail( | |
| title = stringResource(id = R.string.hireConvertible), | |
| content = "${if (hireConvertible!!) "์" else "์"}์", | |
| ) | |
| if(!winterIntern && hireConvertible != null) { | |
| Detail( | |
| title = stringResource(id = R.string.hireConvertible), | |
| content = "${if (hireConvertible) "์" else "์"}์", | |
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ก Codebase verification
API ์๋ต๊ณผ ์ํฐํฐ ๊ฐ์ nullable ํ์ ๋ถ์ผ์น ๋ฐ๊ฒฌ
RecruitmentDetailsEntity์FetchRecruitmentDetailsResponse๊ฐ์ ๋งคํ์์integrationPlan๊ณผhireConvertibleํ๋์ nullable ์ฒ๋ฆฌ๊ฐ ๋๋ฝ๋์์ต๋๋ค. ์ํฐํฐ ํด๋์ค๋ ์ด์ ๋ง์ถฐ ์ ๋ฐ์ดํธ๊ฐ ํ์ํฉ๋๋ค.core/domain/src/main/java/team/retum/usecase/entity/RecruitmentDetailsEntity.ktํ์ผ์์ ํด๋น ํ๋๋ค์ nullable๋ก ์ ์ธํด์ผ ํฉ๋๋ค.toEntity()๋งคํ ํจ์์hireConvertibleํ๋ ๋งคํ์ ์ถ๊ฐํด์ผ ํฉ๋๋ค.๐ Analysis chain
nullable ํ์ ๋ณ๊ฒฝ ๋ฐ ์ถ๊ฐ์ ๋ํ ๊ฒํ
integrationPlan๊ณผhireConvertibleํ๋๊ฐ nullable๋ก ์ค์ ๋ ๊ฒ์ด ํ์ธ๋์์ต๋๋ค. API ์๋ต์์ ํด๋น ํ๋๋ค์ด ์ ํ์ ์ผ๋ก ์ ๊ณต๋ ์ ์์์ ๊ณ ๋ คํ ๋ ์ ์ ํ ๋ณ๊ฒฝ์ผ๋ก ๋ณด์ ๋๋ค.๋ค์ ์คํฌ๋ฆฝํธ๋ฅผ ์คํํ์ฌ ๊ด๋ จ ์ํฐํฐ์ ๋งคํ ๋ก์ง์ด ์ฌ๋ฐ๋ฅด๊ฒ ์ ๋ฐ์ดํธ๋์๋์ง ํ์ธํ๊ฒ ์ต๋๋ค:
Let me generate another script to check the RecruitmentDetailsEntity and its mapping logic:
Let me check one more thing to verify the mapping between the response and entity:
๐ Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 42497
Script:
Length of output: 1842
Script:
Length of output: 2593