Fix crash when opening Recent Files without storage permission#4569
Merged
EmmanuelMess merged 1 commit intoTeamAmaze:release/4.0from Feb 20, 2026
Merged
Conversation
Wrap MediaStore query in listRecentFiles() with try/catch for SecurityException. When READ_EXTERNAL_STORAGE is denied, return the current list instead of letting the exception escape doInBackground() and crash the app.
Member
|
Approved, but the actual issue here is the user being allowed to use the app without permissions given IMO. |
EmmanuelMess
approved these changes
Feb 20, 2026
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix crash when opening Recent Files while storage permission is denied on
release/4.0.Root cause
LoadFilesListTask.listRecentFiles()performs aMediaStorequery that can throwSecurityExceptionwhenREAD_EXTERNAL_STORAGEis denied. The exception escapesAsyncTask.doInBackground()and crashes the app.Fix
Catch
SecurityExceptionaround theMediaStorequery and return the currentrecentFileslist (empty) when permission is denied.Behavior
Issue tracker
Addresses #3396
Verification (manual)
com.amaze.filemanager.debugversionCode 124), buildv3.11.2-76-gd99897689Steps:
Results:
SecurityExceptionBuild checks
./gradlew assembleDebug./gradlew spotlessCheckArtifacts (logcat + screen recordings) captured locally; not included in the repo.