-
Notifications
You must be signed in to change notification settings - Fork 319
fix(DateTimePicker): 修复了 DateTimePicker 即使设置了 autoClose 为 false,点击遮罩层也会重置选项为拨动前的 Bug #3874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
|
@composable-tu noticebar 的示例另拆一个 pr,单独处理。“非通栏样式” 示例不是我们预期展示的内通,可按照视觉稿补充一个“卡片顶部”示例。 视觉稿地址:https://codesign.qq.com/s/589886479758640 预期示例截图:
|
|
@composable-tu 感谢近期对 TDesign 小程序端组件库的关注和贡献,方便的话可以从官网底部扫码入用户群,在用户群联系一下我,提供下收件信息,可为您安排一份 TDesign 周边~~(我在用户群的昵称和 github 同名) |
您好,视觉稿中卡片的背景是深灰色,可是您们的实机 Demo 的卡片背景灰色是浅灰色,和 TDesign 品牌色 Light 放在一起会导致视觉无障碍问题,比较不容易分辨 notice bar 的边界,如下图: |
|
已解决,感谢 |
|
@composable-tu sorry、没顾上消息。我的截图是来自 figma,确实是 figma 和 codesign 两边设计稿没有同步。 我们以 figma 为准,NoticeBar 组件完整的视觉稿如下: |
|
@composable-tu 仅增加 NoticaBar 示例,不集成到组件。 背景色问题,按设计稿执行,maybe 设计同学有自己的考量 😂 |
可是业界应该没有哪个组件库最佳实践是单一平面内深色背景上放浅色卡片的,只有像对话框、弹出层这样的需要用户聚焦的操作才会加深背景以让用户集中直觉到弹窗上。 在用户注意力越来越有限的当下,用户界面中强对比度的色彩使用应该非常谨慎。 |
|
hello,有空先解决下冲突,以及后面可以不用develop分支,切feature分支 |
385a453 to
826c6aa
Compare
这里有些误解,此处的示例为交互环节中的静态展示,旨在表现组件与卡片组合的样式,实际使用中,仍然是需要通过交互触发后弹出。 |
好的,也就是说卡片样式的提示条在设计中是为了在 Popup、Dialog 这些组件场景中使用吗? |
TDesign Component Site Preview Open
|
* chore: merge deploy mode (#3965) * chore: merge deploy mode * chore: rename * chore: pin [email protected] --------- Co-authored-by: 黎伟杰 <[email protected]> * chore: update build package name (#3974) * chore: update build package name * chore: fix typos * chore(indexes): fix sidebar click error in demo (#3980) * chore(indexes): fix sidebar click error in demo * chore: retain controlled usage --------- Co-authored-by: anlyyao <[email protected]> * fix(sidebar): fix color of disabled sidebar (#3982) * fix(sidebar): fix color of disabled sidebar * chore: optimize active state logic --------- Co-authored-by: anlyyao <[email protected]> * chore: update site (#3984) * chore: update site * chore: update image link --------- Co-authored-by: anlyyao <[email protected]> * feat(Drawer): add overlayProps attr (#3978) * feat(Drawer): add overlayProps attr * chore: unified code standard * feat(Watermark): support layout API (#3976) * fix: mini..._npm path * feat: api * feat: function * feat: layout demo * chore: docs * chore: typo * fix(Watermark): fix demo --------- Co-authored-by: anlyyao <[email protected]> * fix(SideBarItem): min-height is set to auto (#3985) * fix(SideBarItem): min-height is set to auto * docs: update css vars * chore(deploy): add static prefix (#3987) * chore: static * chore: add static prefix * 【DOC】修复文档错误、优化脚本 (#3993) * chore: update css generation script * chore: update script * fix(Calendar): fix action button status error (#3996) * chore: publish v1.11.0 (#3999) * chore: publish v1.11.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix typo (#4002) * feat: add qrcode to page watermark (#4004) * docs: generate slots documents for all components (#4008) * docs: generate slots documents for all components * fix: fix test * docs: format * fix(Calendar): fixed initialization error when value[] is combined with switch-mode (#4005) * chore: trusted publisher (#4020) * chore: trusted publisher * chore: 提权 * chore: publishConfig * fix: form提交时能正确获取checkbox-group的值 (#4017) * fix(tabbar): 修复自定义tabbar颜色叠加问题 (#4019) * fix: 修复自定义tabbar颜色叠加问题 * fix: 移 除tabbar-item的背景颜色 * fix(types): type definition error (#4021) * fix(types): type definition error * chore: update common.ts --------- Co-authored-by: anlyyao <[email protected]> * refactor: improve the verification number function (#4015) * fix(action-sheet): exception caused by repeated modification of component initialization data (#4013) * fix(Toast): fix radius error (#4031) * fix(Upload): fixed component display error when changing draggable (#4030) * fix(DateTimePicker): 修复了 DateTimePicker 即使设置了 autoClose 为 false,点击遮罩层也会重置选项为拨动前的 Bug (#3874) * fix: resolve merge conflicts * chore: update ISSUE TEMPLATE --------- Co-authored-by: anlyyao <[email protected]> * chore: publish v1.11.1 (#4034) * chore: publish v1.11.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: 黎伟杰 <[email protected]> Co-authored-by: novlan1 <[email protected]> Co-authored-by: Wesley <[email protected]> Co-authored-by: wū yāng <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Boomkaa <[email protected]> Co-authored-by: betavs <[email protected]> Co-authored-by: composable-tu <[email protected]>
* chore: merge deploy mode (#3965) * chore: merge deploy mode * chore: rename * chore: pin [email protected] --------- Co-authored-by: 黎伟杰 <[email protected]> * chore: update build package name (#3974) * chore: update build package name * chore: fix typos * chore(indexes): fix sidebar click error in demo (#3980) * chore(indexes): fix sidebar click error in demo * chore: retain controlled usage --------- Co-authored-by: anlyyao <[email protected]> * fix(sidebar): fix color of disabled sidebar (#3982) * fix(sidebar): fix color of disabled sidebar * chore: optimize active state logic --------- Co-authored-by: anlyyao <[email protected]> * chore: update site (#3984) * chore: update site * chore: update image link --------- Co-authored-by: anlyyao <[email protected]> * feat(Drawer): add overlayProps attr (#3978) * feat(Drawer): add overlayProps attr * chore: unified code standard * feat(Watermark): support layout API (#3976) * fix: mini..._npm path * feat: api * feat: function * feat: layout demo * chore: docs * chore: typo * fix(Watermark): fix demo --------- Co-authored-by: anlyyao <[email protected]> * fix(SideBarItem): min-height is set to auto (#3985) * fix(SideBarItem): min-height is set to auto * docs: update css vars * chore(deploy): add static prefix (#3987) * chore: static * chore: add static prefix * 【DOC】修复文档错误、优化脚本 (#3993) * chore: update css generation script * chore: update script * fix(Calendar): fix action button status error (#3996) * chore: publish v1.11.0 (#3999) * chore: publish v1.11.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix typo (#4002) * feat: add qrcode to page watermark (#4004) * docs: generate slots documents for all components (#4008) * docs: generate slots documents for all components * fix: fix test * docs: format * fix(Calendar): fixed initialization error when value[] is combined with switch-mode (#4005) * chore: trusted publisher (#4020) * chore: trusted publisher * chore: 提权 * chore: publishConfig * fix: form提交时能正确获取checkbox-group的值 (#4017) * fix(tabbar): 修复自定义tabbar颜色叠加问题 (#4019) * fix: 修复自定义tabbar颜色叠加问题 * fix: 移 除tabbar-item的背景颜色 * fix(types): type definition error (#4021) * fix(types): type definition error * chore: update common.ts --------- Co-authored-by: anlyyao <[email protected]> * refactor: improve the verification number function (#4015) * fix(action-sheet): exception caused by repeated modification of component initialization data (#4013) * fix(Toast): fix radius error (#4031) * fix(Upload): fixed component display error when changing draggable (#4030) * fix(DateTimePicker): 修复了 DateTimePicker 即使设置了 autoClose 为 false,点击遮罩层也会重置选项为拨动前的 Bug (#3874) * fix: resolve merge conflicts * chore: update ISSUE TEMPLATE --------- Co-authored-by: anlyyao <[email protected]> * chore: publish v1.11.1 (#4034) * chore: publish v1.11.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: reuse TDesignOteam spell-check (#4043) * fix(Picker): optimize scrolling performance when large data (#4014) * fix: 修复大量数据picker卡顿问题 * fix(picker): 使用虚拟滚动优化性能 * fix(picker): 完善使用虚拟滚动优化性能 * fix(picker): 去掉日志 * fix(picker): 移除css * docs: update css vars --------- Co-authored-by: Boomkaa <[email protected]> Co-authored-by: anlyyao <[email protected]> * feat(Calendar): support allowSameDay prop (#4045) * feat(Cascader): enhance the capabilities of the keys property (#4044) * feat(Cascader): enhance the capabilities of the keys property * chore(Radio): root node supplements the disabled state classname * test: update snapshots * chore(git): main 分支合并 develop 分支,冲突时优先使用develop 分支代码 (#4036) * chore(site): added miniprogram-chat entry (#4050) * feat(Picker): support visibleItemCount prop (#4052) * feat(Picker): support visibleItemCount prop * test: update snapshots * chore(site): support ai-search (#4048) * chore(site): support ai-search * chore: update common * docs(site): remove changelog for miniprogram-chat (#4054) * chore: publish v1.11.2 (#4053) * chore: publish v1.11.2 * chore: changelog's changes * fix: fix lint --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: 黎伟杰 <[email protected]> Co-authored-by: novlan1 <[email protected]> Co-authored-by: Wesley <[email protected]> Co-authored-by: wū yāng <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Boomkaa <[email protected]> Co-authored-by: betavs <[email protected]> Co-authored-by: composable-tu <[email protected]> Co-authored-by: jarmywang <[email protected]> Co-authored-by: Boomkaa <[email protected]>
* chore: merge deploy mode (#3965) * chore: merge deploy mode * chore: rename * chore: pin [email protected] --------- Co-authored-by: 黎伟杰 <[email protected]> * chore: update build package name (#3974) * chore: update build package name * chore: fix typos * chore(indexes): fix sidebar click error in demo (#3980) * chore(indexes): fix sidebar click error in demo * chore: retain controlled usage --------- Co-authored-by: anlyyao <[email protected]> * fix(sidebar): fix color of disabled sidebar (#3982) * fix(sidebar): fix color of disabled sidebar * chore: optimize active state logic --------- Co-authored-by: anlyyao <[email protected]> * chore: update site (#3984) * chore: update site * chore: update image link --------- Co-authored-by: anlyyao <[email protected]> * feat(Drawer): add overlayProps attr (#3978) * feat(Drawer): add overlayProps attr * chore: unified code standard * feat(Watermark): support layout API (#3976) * fix: mini..._npm path * feat: api * feat: function * feat: layout demo * chore: docs * chore: typo * fix(Watermark): fix demo --------- Co-authored-by: anlyyao <[email protected]> * fix(SideBarItem): min-height is set to auto (#3985) * fix(SideBarItem): min-height is set to auto * docs: update css vars * chore(deploy): add static prefix (#3987) * chore: static * chore: add static prefix * 【DOC】修复文档错误、优化脚本 (#3993) * chore: update css generation script * chore: update script * fix(Calendar): fix action button status error (#3996) * chore: publish v1.11.0 (#3999) * chore: publish v1.11.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix typo (#4002) * feat: add qrcode to page watermark (#4004) * docs: generate slots documents for all components (#4008) * docs: generate slots documents for all components * fix: fix test * docs: format * fix(Calendar): fixed initialization error when value[] is combined with switch-mode (#4005) * chore: trusted publisher (#4020) * chore: trusted publisher * chore: 提权 * chore: publishConfig * fix: form提交时能正确获取checkbox-group的值 (#4017) * fix(tabbar): 修复自定义tabbar颜色叠加问题 (#4019) * fix: 修复自定义tabbar颜色叠加问题 * fix: 移 除tabbar-item的背景颜色 * fix(types): type definition error (#4021) * fix(types): type definition error * chore: update common.ts --------- Co-authored-by: anlyyao <[email protected]> * refactor: improve the verification number function (#4015) * fix(action-sheet): exception caused by repeated modification of component initialization data (#4013) * fix(Toast): fix radius error (#4031) * fix(Upload): fixed component display error when changing draggable (#4030) * fix(DateTimePicker): 修复了 DateTimePicker 即使设置了 autoClose 为 false,点击遮罩层也会重置选项为拨动前的 Bug (#3874) * fix: resolve merge conflicts * chore: update ISSUE TEMPLATE --------- Co-authored-by: anlyyao <[email protected]> * chore: publish v1.11.1 (#4034) * chore: publish v1.11.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: reuse TDesignOteam spell-check (#4043) * fix(Picker): optimize scrolling performance when large data (#4014) * fix: 修复大量数据picker卡顿问题 * fix(picker): 使用虚拟滚动优化性能 * fix(picker): 完善使用虚拟滚动优化性能 * fix(picker): 去掉日志 * fix(picker): 移除css * docs: update css vars --------- Co-authored-by: Boomkaa <[email protected]> Co-authored-by: anlyyao <[email protected]> * feat(Calendar): support allowSameDay prop (#4045) * feat(Cascader): enhance the capabilities of the keys property (#4044) * feat(Cascader): enhance the capabilities of the keys property * chore(Radio): root node supplements the disabled state classname * test: update snapshots * chore(git): main 分支合并 develop 分支,冲突时优先使用develop 分支代码 (#4036) * chore(site): added miniprogram-chat entry (#4050) * feat(Picker): support visibleItemCount prop (#4052) * feat(Picker): support visibleItemCount prop * test: update snapshots * chore(site): support ai-search (#4048) * chore(site): support ai-search * chore: update common * docs(site): remove changelog for miniprogram-chat (#4054) * chore: publish v1.11.2 (#4053) * chore: publish v1.11.2 * chore: changelog's changes * fix: fix lint --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add chat series components (#4010) * feat(site): add AI Chat routing * chore(demo): update demo * chore: update the directory structure again * chore: update liveUrl for dev * feat: update qrcode for page * docs: update title * feat(chat): 更新聊天组件及相关示例代码 * fix: 修改common路径 * fix: 修改代码引入路径 * fix: attachments对齐pc端 * fix: chat-loading样式问题修复 * feat(site): add AI Chat routing * chore(demo): update demo * chore: update the directory structure again * chore: update liveUrl for dev * feat: update qrcode for page * docs: update title * feat(chat): 更新聊天组件及相关示例代码 * fix: 修改common路径 * fix: 修改代码引入路径 * fix: attachments对齐pc端 * fix: chat-loading样式问题修复 * style: fixed multiple style errors * fix(site): fix page path error * style(demo): fix style * fix: 修复chatContentProps的使用问题 * chore: fixed multiple errors in multiple components * feat: 文案调整 * feat: chat图片示例调整 * style(ChatMarkdown): use css token * fix(ChatActionbar): update demo * chore: styleIsolation configuration is migrated from options to json * fix: chat示例样式调整;chatSender示例增加背景色;chatSender组件输入框的最大最小高度按照按照rpx传值 * feat(ChatActionBar): update icon * feat(ChatLoading): change circle to dots type * chore(ChatActionbar): named according to BEM * chore(ChatLoading): named according to BEM * chore(ChatThinking): named according to BEM * chore(ChatContent): named according to BEM * refactor(ChatList): remove old chat example files and add new chat list component with examples * feat: 补充遗漏样式 * chore(Attachments): named according to BEM * chore(ChatMessage): named according to BEM * chore: update app.json * chore(ChatMarkdown): named according to BEM * chore(ChatSender): named according to BEM * chore(ChatList): named according to BEM * chore: format * feat: 更改为tdesign-miniprogram引入chat组件 * feat(ChatList): add scrollToBottom method demo * fix: 修复多个组件示例源码展示问题 * docs: update README * docs: update getting-started * feat: 完善文档 * feat: 新增错误状态 * fix: remove isMarkdown property * refactor: rename event from handleAction to actions in ChatActionbar component * refactor: rename event from expandChange to collapsedChange in ChatThinking component * fix: 修复思考过程内容首行换行问题 * feat: refactor: 移除 imageProps 属性,新增 FileItem 尺寸及模式属性 * docs: update README to clarify items property description in attachments * docs: 移除 chat-sender 组件 update:visible 事件说明 * fix(demo): fixed multiple style issues * fix(demo): fixed multiple style issues * feat(ChatSender): 修改文档描述 * feat(Attachments): use the multiply icon instead * fix(ChatLoading): fix text spacing error * refactor(ChatSender): remove type property from upload configuration and update related logic * chore(site): update site.config.mjs file * chore(ChatMessage): setting max-width * fix(Attachments): fix file margin-top erro * feat: 更新聊天内容类型及界面插槽名称 * refactor: 移除未使用样式及更新注释描述 * style: 移除 chat-actionbar 组件未使用样式代码 * docs(Chat): update api docs (#4038) * docs(Chat): update api docs * docs: update * chore: using props.ts file * fix(Demo): fix multiple example bugs * chore: remove irrelevant content * feat: 新增动画与状态属性,优化消息结构及性能 * refactor: update submodule * fix(chat-list): 修复控制台告警 * docs: add code snippet link (#4041) * chore: update _common * fix(Demo): fix console warnings * docs: add code snippet link * docs: remove irrelevant changelogs * docs(chat): fix doc link (#4051) * docs(chat): fix doc link * chore: fix doc * docs: update api docs --------- Co-authored-by: zydemail <[email protected]> Co-authored-by: nekowu <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: waiterxiaoyy <[email protected]> Co-authored-by: liweijie0812 <[email protected]> * Bugfix/getting started (#4059) * fix component path in getting-started documentation * update submodule * docs(chat-site): support component changelog (#4057) * docs(chat-site): support component changelog * chore: update common * ci: add node24 test build (#4056) * 更新 ci.yml * 更新 ci.yml * chore: update common --------- Co-authored-by: 黎伟杰 <[email protected]> Co-authored-by: novlan1 <[email protected]> Co-authored-by: Wesley <[email protected]> Co-authored-by: wū yāng <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Boomkaa <[email protected]> Co-authored-by: betavs <[email protected]> Co-authored-by: composable-tu <[email protected]> Co-authored-by: jarmywang <[email protected]> Co-authored-by: Boomkaa <[email protected]> Co-authored-by: zydemail <[email protected]> Co-authored-by: nekowu <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: waiterxiaoyy <[email protected]>





🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
此仓库的 GitHub Issue Bug 反馈模板将“重现链接”定义成了单行文本框。
如果反馈者的复现片段很短,他可以直接粘贴代码而非重新生成完整的项目代码片段,但是这种场景下使用单行文本框会存在不便之处。我提交的更改允许反馈者在首次反馈时就可以使用富文本能力粘贴代码,从而无需二次编辑。
[date-time-picker] 当 auto-close 为 false 时,打开时间选择器,拨动选项后点击遮罩层,选择器的选中时间会还原回拨动前的时间 #3876
由于 Picker 组件未传递
close-on-overlay-click="{{autoClose}}",导致 DateTimePicker 被 Picker 及更上游的 Popup 错误传递了triggerEvent('visible-change', false)事件,从而导致了 DateTimePicker 即使设置了autoClose为false,点击遮罩层也会重置选项为拨动前的 Bug📝 更新日志
autoClose为false时,点击遮罩层会重置选项为拨动前选项值的问题☑️ 请求合并前的自查清单