Skip to content

fix(SideBarItem): min-height is set to auto #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2025
Merged

fix(SideBarItem): min-height is set to auto #3985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
665ee69
fix(SideBarItem): min-height is set to auto
anlyyao Oct 10, 2025
4297c5c
docs: update css vars
anlyyao Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/side-bar-item/side-bar-item.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

@side-bar-color: var(--td-side-bar-color, @text-color-primary);
@side-bar-font-size: var(--td-side-bar-font-size, 32rpx);
@side-bar-item-height: var(--td-side-bar-item-height, 112rpx);
@side-bar-item-height: var(--td-side-bar-item-height, auto);
@side-bar-item-line-height: var(--td-side-bar-item-line-height, 48rpx);
@side-bar-bg-color: var(--td-side-bar-bg-color, @bg-color-secondarycontainer);
@side-bar-disabled-color: var(--td-side-bar-disabled-color, @text-color-disabled);
Expand Down
2 changes: 1 addition & 1 deletion packages/components/side-bar/README.en-US.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ Name | Default Value | Description
--td-side-bar-disabled-color | @text-color-disabled | -
--td-side-bar-font-size | 32rpx | -
--td-side-bar-icon-size | 40rpx | -
--td-side-bar-item-height | 112rpx | -
--td-side-bar-item-height | auto | -
--td-side-bar-item-line-height | 48rpx | -
2 changes: 1 addition & 1 deletion packages/components/side-bar/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,5 @@ value | String / Number | - | 当前选项的值 | N
--td-side-bar-disabled-color | @text-color-disabled | -
--td-side-bar-font-size | 32rpx | -
--td-side-bar-icon-size | 40rpx | -
--td-side-bar-item-height | 112rpx | -
--td-side-bar-item-height | auto | -
--td-side-bar-item-line-height | 48rpx | -
10 changes: 5 additions & 5 deletions packages/tdesign-miniprogram/site/scripts/generate-css-vars.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import resolveCwd from './utils.mjs';

const COMPONENT_NAME = process.argv[process.argv.indexOf('--NAME') + 1]; // 在 --NAME 后面
const ROOT_DIR = COMPONENT_NAME.includes('chat')
? resolveCwd('/packages/pro-components')
: resolveCwd('/packages/components');
? resolveCwd('../../../packages/components')
: resolveCwd('../../../packages/components');

const combine = {
avatar: ['avatar-group', 'avatar'],
Expand Down Expand Up @@ -57,14 +57,14 @@ const generateCssVariables = async (componentName) => {

const list = file.match(matchReg)?.sort();

list?.forEach((item, index) => {
list?.forEach((item) => {
cssVariableBodyContent += `${item.slice(1, item.indexOf(',')).trim()} | ${item
.slice(item.indexOf(',') + 2, item.length - 1)
.trim()} | -${index === list.length - 1 ? '' : ' \n'}`;
.trim()} | -${' \n'}`;
});
});

return cssVariableBodyContent;
return cssVariableBodyContent.trimEnd();
};

/**
Expand Down
Loading