Fix RDP audio output and dynamic session resize#625
Open
allxm4 wants to merge 1 commit intoTermix-SSH:mainfrom
Open
Fix RDP audio output and dynamic session resize#625allxm4 wants to merge 1 commit intoTermix-SSH:mainfrom
allxm4 wants to merge 1 commit intoTermix-SSH:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes two issues with RDP connections: no audio output and static session resolution that only CSS-scales instead of actually resizing.
Changes Made
Audio fix (
guacamole-server.ts)The custom
connectionDefaultSettingsfor RDP silently wipes guacamole-lite's built-inaudio: ['audio/L16']default. Without it, guacd is told no audio formats are supported and skips the audio channel entirely. Addingaudio: ["audio/L16"]back restores it.Audio fix (
GuacamoleDisplay.tsx)client.onaudiowas never handled, so incoming audio streams were silently dropped. Added a handler that passes streams toGuacamole.AudioPlayer.getInstance()for playback via the Web Audio API.Resize fix (
GuacamoleDisplay.tsx)The existing
ResizeObserveronly calleddisplay.scale()— a CSS zoom that keeps the RDP session at its original resolution. Added a debouncedclient.sendSize(w, h)call so the RDP server is told to actually redraw at the new resolution. The backend already had"resize-method": "display-update"configured, so only the client-side signal was missing.Type definitions (
guacamole-common-js.d.ts)Added missing
sendSize,onaudio, andAudioPlayerto the type definitions.Related Issues
None
Checklist