feat: implement SSH algorithms mapping and refactor cipher usage acro…#627
Open
Chakyiu wants to merge 1 commit intoTermix-SSH:mainfrom
Open
feat: implement SSH algorithms mapping and refactor cipher usage acro…#627Chakyiu wants to merge 1 commit intoTermix-SSH:mainfrom
Chakyiu wants to merge 1 commit intoTermix-SSH:mainfrom
Conversation
|
I got this issue and cannot connect to any of my servers. Any shortcuts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ss SSH modules
Overview
Short summary of what this PR does
Changes Made
ssh2 builds its supported cipher list at startup using crypto.getCiphers(). It maps 'chacha20-poly1305@openssh.com' to the OpenSSL name 'chacha20'. In Electron's bundled Node.js, 'chacha20' isn't in crypto.getCiphers() (unlike the system Node.js used in dev mode), so chacha20-poly1305@openssh.com gets excluded from the supported list.
Related Issues
None
Screenshots / Demos
Open in Server Stats Error
4:50:56 PM Starting metrics collection
4:50:56 PM Resolving DNS for nowservice.cc
4:50:56 PM Connecting to xxx.com:22
4:50:56 PM Initiating SSH handshake
4:50:56 PM Authenticating with SSH key
4:50:56 PM Failed to start metrics: Unsupported algorithm: chacha20-poly1305@openssh.com
Checklist