ci(deploy): move aggregation step into deploy #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflows for working with pages artifacts are not as smart as the standard artifact routines. As such, the aggregation of previous artifacts must take place in the deploy script so the final artifact generated will have the same run-id as the deploy step that fetches it. Fixes: 2d64c49 (feat(cicd): automated builds and deployment to pages, 2024-11-19) Signed-off-by: Randolph Sapp <[email protected]>
StaticRocket
requested review from
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
|
Actual working run: https://github.com/StaticRocket/processor-sdk-doc/actions/runs/12300934415 Somehow the CI branch in my last PR was not correctly updated and a previous (broken) version of the pipeline was merged. |
cshilwant
approved these changes
Dec 12, 2024
praneethbajjuri
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflows for working with pages artifacts are not as smart as the standard artifact routines. As such, the aggregation of previous artifacts must take place in the deploy script so the final artifact generated will have the same run-id as the deploy step that fetches it.
Fixes: 2d64c49 (feat(cicd): automated builds and deployment to pages, 2024-11-19)