Feature/no config #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaticRocket
requested review from
cshilwant,
praneethbajjuri and
sskartheekadivi
StaticRocket
force-pushed
the
feature/no-config
branch
2 times, most recently
from
f06ad10 to
ad812d4
Compare
Contributor
|
+1 |
Member
|
@aniket-l FYI |
praneethbajjuri
previously approved these changes
Nov 2, 2024
Member
Author
|
Just realized that README tells people to build RTOS for J721E, which is completely broken right now. Guess I need to change that to AM57. |
StaticRocket
force-pushed
the
feature/no-config
branch
from
0cb0b52 to
482c5c9
Compare
pylint: [unused-import] Unused import shlex [W0611] (W) Signed-off-by: Randolph Sapp <[email protected]>
Disable C0103 since sphinx conf variables must be in the global context and are lowercase. Disable W0622 since the sphinx copyright variable clashes with a python internal definition. Signed-off-by: Randolph Sapp <[email protected]>
The u prefix for strings is no longer necessary in Python >=3.0 [W1406] Signed-off-by: Randolph Sapp <[email protected]>
Move the sphinx config file to the root of the project to prepare for the dynamic config loader. Signed-off-by: Randolph Sapp <[email protected]>
Rename this directory to something that follows the python module naming convention so we can import these directly. Signed-off-by: Randolph Sapp <[email protected]>
Instead of using the config step to concatenate files, just use the running Python interpreter to set things up. Signed-off-by: Randolph Sapp <[email protected]>
Prune old variables that are no longer needed. Signed-off-by: Randolph Sapp <[email protected]>
Remove this stub file now. It's been integrated into the main conf file. Signed-off-by: Randolph Sapp <[email protected]>
Ignore the main replacement vars that all platforms should supply. We should probably centralize this list somewhere and provide some defaults later. Signed-off-by: Randolph Sapp <[email protected]>
Update build instructions for the new build process now that we skip the config step. Signed-off-by: Randolph Sapp <[email protected]>
I seem to have forgotten how test works. Just use the test exit code directly. Signed-off-by: Randolph Sapp <[email protected]>
StaticRocket
force-pushed
the
feature/no-config
branch
from
482c5c9 to
75d9abb
Compare
StaticRocket
dismissed
cshilwant’s stale review
There do not appear to be any conflicts
Member
Author
|
This is now blocking progress on #20 |
Member
Agreed, but this would need a +1 from @uditkumarti @aniket-l @ravi-rahul since it updates the documentation build command & will affect their documentation building & syncing bots once they pull this changes in their fork. I'm reviewing these changes, give me a day or two to review & get back |
Collaborator
|
@praneethbajjuri @StaticRocket @cshilwant cc: @ravi-rahul |
aniket-l
approved these changes
Nov 13, 2024
praneethbajjuri
approved these changes
Nov 13, 2024
cshilwant
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a useful chunk out of my rewrite of the config system since that was never approved in it's complete form.
This eliminates the need for the config step.