fix(PRU-ICSS): Update cut thru documentation for switch mode #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeghanaMalladiTI
requested review from
cshilwant,
StaticRocket,
praneethbajjuri,
uditkumarti,
aniket-l and
VeeruPrudhvi
as code owners
|
New warnings found with rstcheck: |
|
Please fixup rst reported error |
MeghanaMalladiTI
force-pushed
the
cutthru-doc-fix
branch
from
58bd36d to
66162b7
Compare
|
New warnings found with rstcheck: |
|
Ignore that warning. It's an issue with rstcheck that I still need to fix. Advanced features of sphinx directives tend to confuse it. |
dao-qiu
suggested changes
Oct 7, 2025
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet_Switch.rst
Outdated
Show resolved
Hide resolved
StaticRocket
requested changes
Oct 7, 2025
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet_Switch.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet_Switch.rst
Show resolved
Hide resolved
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet_Switch.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet_Switch.rst
Outdated
Show resolved
Hide resolved
|
Please address the vale comments |
MeghanaMalladiTI
force-pushed
the
cutthru-doc-fix
branch
from
66162b7 to
0364d12
Compare
|
New warnings found with rstcheck: |
MeghanaMalladiTI
force-pushed
the
cutthru-doc-fix
branch
from
0364d12 to
0ee9135
Compare
|
New warnings found with rstcheck: |
dao-qiu
suggested changes
Oct 8, 2025
| cut through is working properly. This order ensures that firmware is loaded with the | ||
| expected cut through value. | ||
|
|
||
| Below steps order is suggested for enabling cut through in switch mode. Setting up switch mode will automatically stop and start the firmware so no need to bring links down and back up again. |
There was a problem hiding this comment.
If the below code block is going to be removed, change note to:
"Set up the cut through value first before enabling switch mode to ensure that cut through is working properly. This order ensures that firmware is loaded with the expected cut through value. Setting up switch mode will automatically stop and start the firmware so no need to bring links down and back up again. "
Cut thru documentation has a gap on the order of steps in which the cut thru needs to be enabled. This commit fixes it by adding the recommended steps order to follow for enabling cut thru. Signed-off-by: Meghana Malladi <[email protected]>
MeghanaMalladiTI
force-pushed
the
cutthru-doc-fix
branch
from
0ee9135 to
13cd981
Compare
|
New warnings found with rstcheck: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cut thru documentation has a gap on the order of steps in which the cut thru needs to be enabled. This commit fixes it by adding the recommended steps order to follow for enabling cut thru.