-
Couldn't load subscription status.
- Fork 71
Bugfix/clean includes #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/clean includes #85
Conversation
|
New warnings found with rstcheck: |
c79e1f8 to
a13dd35
Compare
|
New warnings found with rstcheck: |
|
@StaticRocket Remove the include definition from source/debian/How_to_Guides/index_How_to_Guides.rst file and from the Makefile as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1fd40d9 to
9683c31
Compare
|
New warnings found with rstcheck: |
|
New warnings found with rstcheck: |
|
@cshilwant @jeevantelukula updated |
9683c31 to
390b22b
Compare
|
Rebase to get new CI messages |
|
New warnings found with rstcheck: |
|
New warnings found with rstcheck: |
|
Going to be helpful and also address the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StaticRocket Can you remove it from clean target of the Makefile as well?
Remove the replacevars include definitions that snuck in around the time we reworked the build to eliminate the need for the replacevars file. Signed-off-by: Randolph Sapp <[email protected]>
Update documentation around replacement variables. Signed-off-by: Randolph Sapp <[email protected]>
Fix the following warning: Enumerated list ends without a blank line; unexpected unindent. Signed-off-by: Randolph Sapp <[email protected]>
Was keeping this clean step around to try and passively remove this file from users that may not be keeping track of upstream changes. Now we should be good to delete it. Signed-off-by: Randolph Sapp <[email protected]>
Prune these paths now that we have tweaked the build system. Signed-off-by: Randolph Sapp <[email protected]>
b2850dd to
7b0df0e
Compare
|
New warnings found with rstcheck: |
|
@praneethbajjuri for final ack |
Update documentation around replacement variables.
Remove the replacevars include definitions that snuck in around the time
we reworked the build to eliminate the need for replacevars.