-
Notifications
You must be signed in to change notification settings - Fork 72
AM62x: Add minimal platform board port guide #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AM62x: Add minimal platform board port guide #9
Conversation
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use .rst.inc. This confuses lexers. Please use the _<Name>.rst convention for rst files intended to be included by other files.
|
rebase on master to get the checkers to run |
d599b1d to
3fc798b
Compare
|
New warnings found with rstcheck: |
3fc798b to
8f4ac79
Compare
|
New warnings found with rstcheck: |
8f4ac79 to
b730e33
Compare
|
New warnings found with rstcheck: |
b730e33 to
de8936a
Compare
|
New warnings found with rstcheck: |
|
New warnings found with rstcheck: |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original feedback not addressed. Commits break contribution guidelines.
57c2cb7 to
56201f8
Compare
addressed. Please review @StaticRocket |
commit ef600dd (Revert "AM62x: Add minimal platform development guide") removed references of minimal platform guide till updates to the linked app note were addressed. https://www.ti.com/lit/pdf/spradd1 is now published. Enable back the minimal platform board porting guide for AM62x. Signed-off-by: Praneeth Bajjuri <[email protected]>
56201f8 to
d6c0693
Compare
bryanbrattlof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @praneethbajjuri
jmenti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, ack
This reverts commit ef600dd.
https://www.ti.com/lit/pdf/spradd1 is now published.
Enable back the minimal platform board porting guide for AM62x.