-
-
Notifications
You must be signed in to change notification settings - Fork 28
chore: add nim_test.yml
#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, besides the proposed change and this:
I propose replacing the Bash scripts in this PR with a nimscript task from #21.
Sorry I meant checking against devel too. |
|
I do not want to setup a Nimble/Atlas project file. I have had many problems switching between developer and user versions of the repositories. I am confused by the recent changes brought to Nimble that made it quite unstable. ) The imposed Nimble directory structure will probably conflict with the directory structure of the Algorithms repository. Nimble is not really necessary. What advantages does it really bring ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improves greatly the repository's state and workflow. I need @Panquesito7 's approval to merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks! 🚀
|
Nice work everybody! |
This PR adds a very simple CI for this repo (and fixes some bugs in the existing
*.nimfiles).Note that there are still some warnings in the existing files.
The future work is definitely to setup this project usingnimble, but this also would require things like project structure change, which is way too far beyond the scope of this PR.Regarding the shellscripts: #21