feat: add O(log n) lucas number implementation using matrix exponentiation #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #907 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 319 319
Lines 20807 20832 +25
=======================================
+ Hits 19834 19859 +25
Misses 973 973 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ation Added dynamic_lucas_number_logn function that uses matrix exponentiation to compute Lucas numbers in logarithmic time complexity, compared to the existing O(n) and O(n) recursive implementations. Updated module exports to include the new function and added comprehensive test coverage for all three implementations.
Use iterator with enumerate() instead of range-based indexing to satisfy clippy::needless_range_loop lint.
technusm1
force-pushed
the
update-lucas-series-implementation
branch
from
f9597ed to
dd519a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
dynamic_lucas_number_lognfunction that uses matrix exponentiation to compute nth Lucas number in O(log n) time complexity, compared to the existing O(n) dynamic programming and O(n) recursive implementations.Changes
Test plan
The implementation uses fast matrix exponentiation with the recurrence relation matrix [[1,1],[1,0]] to achieve logarithmic time complexity.