Weight processing/position emebeddings attention#1218
Merged
jlarson4 merged 2 commits intodev-3.x-canaryfrom Mar 28, 2026
Merged
Weight processing/position emebeddings attention#1218jlarson4 merged 2 commits intodev-3.x-canaryfrom
jlarson4 merged 2 commits intodev-3.x-canaryfrom
Conversation
…s introduced into Hookedtransformer by transformers v5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a series of weight processing bugs. Most were caused in HookedTransformer by the transition to
transformers v5Hooked Transformer changes
default_prepend_bos=Falseadd_bos_tokenexclusion list to avoidtransformers v5errorpad_token_idis not set, defaults toNoneif not provided (pad_token_idrequired intransformers v5)center_unembedandfold_value_biaseswere erroneously disabled for all modelsTransformerBridge changes
o_projType of change
Please delete options that are not relevant.
Checklist: