Bump glam upper bound to <= 0.30
#62
Conversation
|
Looks like we need to bump |
MarijnS95
changed the title
glam upper bound to <= 0.25glam upper bound to <= 0.30\
MarijnS95
changed the title
glam upper bound to <= 0.30\glam upper bound to <= 0.30
| fn local_coord_to_offset(&self, xyz: LocalCoord) -> Index { | ||
| Index( | ||
| (((xyz.0[0] & (Self::DIM - 1)) >> Self::TOTAL) << (2 * Self::LOG_2_DIM)) | ||
| + (((xyz.0[1] & (Self::DIM - 1)) >> Self::TOTAL) << Self::LOG_2_DIM) | ||
| + ((xyz.0[2] & (Self::DIM - 1)) >> Self::TOTAL), | ||
| ) |
There was a problem hiding this comment.
@jasperdewinther can you double-check this? It seems surprising that going from local coordinates shifts right by Self::TOTAL, but going from offset to local coordinates below does not. That is only performed in offset_to_global_coord(). Perhaps it is in the wrong place?
| [dev-dependencies] | ||
| bevy = { version = "0.11", default-features = false, features = ["bevy_pbr"] } | ||
| bevy-aabb-instancing = "0.10" | ||
| bevy_egui = "0.22" | ||
| smooth-bevy-cameras = "0.9" |
There was a problem hiding this comment.
I have tried but failed (thus far) to push the dependency updates through to these crates. Will try again but we might just delete the samples as it's preventing us from bumping an entire dependency stack.
There was a problem hiding this comment.
Trying in ForesightMiningSoftwareCorporation/bevy_aabb_instancing#27 again but Bevy internals are incredibly complex, especially when never using it and jumping straight into deep custom rendering implementations and upgrading it from 0.11 to 0.17 with many new/changed abstractions.
Supersedes #61