-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(search): implement FTS5 w/ sqlite for faster and better searching #6839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
perfectra1n
wants to merge
23
commits into
main
Choose a base branch
from
feat/rice-searching-with-sqlite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1db4971
feat(search): implement FST5 w/ sqlite for faster and better searching
perfectra1n 21aaec2
feat(search): also fix tests for new fts functionality
perfectra1n 053f722
feat(search): try to get fts search to work in large environments
perfectra1n 5b79e0d
feat(search): try to decrease complexity
perfectra1n 37d0136
feat(search): try to deal with huge dbs, might need to squash later
perfectra1n 7c5553b
feat(search): further improve fts search
perfectra1n b09a2c3
feat(search): I honestly have no idea what I'm doing
perfectra1n 8572f82
Revert "feat(search): I honestly have no idea what I'm doing"
perfectra1n f529ddc
Revert "feat(search): further improve fts search"
perfectra1n 0afb8a1
Revert "feat(search): try to deal with huge dbs, might need to squash…
perfectra1n 06b2d71
Revert "feat(search): try to decrease complexity"
perfectra1n d074841
Revert "feat(search): try to get fts search to work in large environm…
perfectra1n 58c2252
feat(search): try a ground-up sqlite search approach
perfectra1n d992a5e
Merge branch 'main' into feat/rice-searching-with-sqlite
perfectra1n 253da13
feat(search): try again to get fts5 searching done well
perfectra1n 1098809
feat(search): get the correct comparison and rice out the fts5 search
perfectra1n 321752a
Merge branch 'main' into feat/rice-searching-with-sqlite
perfectra1n 16912e6
fix(search): resolve compilation issue due to performance log in new …
perfectra1n 052e28a
feat(search): if the search is empty, return all notes
perfectra1n b8aa740
feat(tests): create a ton of tests for the various search capabilitie…
perfectra1n 942647a
fix(search): get rid of exporting dbConnection
perfectra1n da03020
fix(tests): resolve issues with new search tests not passing
perfectra1n 5f17736
fix(tests): rename some of the silly-ily named tests
perfectra1n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double-check if a component index is really needed? The component ID is used on the client side to distinguish which UI element made the change to avoid accidentally updating the very same editor that the user is using.
On the server side I don't think the components are really necessary.