Fix tree state preservation for table view #7056
Draft
+192
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features added: - Preserve tree expansion state during data refreshes using dataTreeStartExpanded - Add localStorage persistence for expansion state across app sessions - Track expand/collapse events externally to avoid Tabulator setData() limitations - Each note maintains independent expansion state keyed by noteId - Prevent visual collapse/re-expand flicker during table operations Implementation details: - Use Tabulator's native dataTreeStartExpanded instead of post-hoc restoration - External state tracking with React refs for session persistence - localStorage integration for cross-session state preservation - Proper event chaining to maintain existing context menu functionality - Debounced refresh handling to prevent overlapping state updates Fixes: - Tree nodes no longer collapse during add/delete/edit operations - Expansion state persists across app restarts and navigation - Context menu 'insert row above/below' options restored - No interference with existing table functionality
dosubot
bot
added
the
size:L
bangbangbanggit
changed the title
eliandoran
requested changes
Sep 23, 2025
Comment on lines
+33
to
+45
| useEffect(() => { | ||
| const storageKey = `trilium-tree-expanded-${note.noteId}`; | ||
| try { | ||
| const stored = localStorage.getItem(storageKey); | ||
| if (stored) { | ||
| const expandedIds = JSON.parse(stored); | ||
| expandedRowsRef.current = new Set(expandedIds); | ||
| console.log('Loaded expansion state from storage:', expandedIds); | ||
| } | ||
| } catch (e) { | ||
| console.warn('Failed to load tree expansion state:', e); | ||
| } | ||
| }, [note.noteId]); |
There was a problem hiding this comment.
The idea is good but Trilium does not use the local storage feature at all. All data in Trilium is managed within the SQL database. For storing tree expansion state, ideally you should use the already provided view storage see ViewModeProps<TableConfig>.
Since the user can be expanding/collapsing a lot of times, it's best to delay the saving in a spaced update.
Comment on lines
+74
to
+77
| persistenceMode: "local", | ||
| persistence: { | ||
| tree: true | ||
| } |
There was a problem hiding this comment.
As mentioned previously, we don't store data in local storage, we store it in an attachment inside the note. We must not break this functionality.
| ...rowEditingEvents | ||
| ...rowEditingEvents, | ||
| tableBuilt: () => { | ||
| console.log('Table built - setting up tree event tracking'); |
There was a problem hiding this comment.
There are many debug logs inside the PR, please get rid of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Features added:
Implementation details: