Skip to content

Conversation

SharkPool-SP
Copy link
Collaborator

@SharkPool-SP SharkPool-SP commented Jan 2, 2025

THIS MUST BE MERGED FIRST:
TurboWarp/scratch-gui#979

Super Mega Update to the Files Extension to port over many new features from my expansion of the extension.
This includes:

  • getting file meta data
  • new encoding types
  • modal selector customization
  • basic usage of the File API (write to files, open folders, delete selected files, etc)

Closes:
#1603
#156
#837

Files Expanded:
https://github.com/SharkPool-SP/SharkPools-Extensions/blob/main/extension-code/Files-Expanded.js

@SharkPool-SP SharkPool-SP changed the title files -- Update with code from Files Expanded files.js -- Update with code from Files Expanded Jan 2, 2025
@CubesterYT
Copy link
Member

!format

@SharkPool-SP SharkPool-SP added the pr: new extension Pull requests that add a new extension label Jan 4, 2025
@yuri-kiss

This comment was marked as abuse.

@CubesterYT CubesterYT added pr: change existing extension Pull requests that change an existing extension and removed pr: new extension Pull requests that add a new extension labels Jan 4, 2025
@SharkPool-SP
Copy link
Collaborator Author

Related PR: #1594 Related API suggestion: #1594 (comment) (on the PR comments)

TurboWarp/scratch-gui#979

@rkxspace
Copy link

Ah, someone that actually knows what they are doing. I'm just going to close mine, since this does everything that mine would do (and better).
Plus, I've lost interest in developing mine so it is better off.

@rkxspace rkxspace mentioned this pull request Feb 16, 2025
@yuri-kiss

This comment was marked as abuse.

@GarboMuffin GarboMuffin restored the SharkPool-SP-patch-1 branch February 27, 2025 14:53
@GarboMuffin GarboMuffin reopened this Feb 27, 2025
@WAYLIVES
Copy link

WAYLIVES commented Mar 2, 2025

!format

@SharkPool-SP
Copy link
Collaborator Author

!format

Copy link

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more indepth review is indeed required.

* @param {Uint8Array} buffer
* @returns {string} base64
*/
function bufferToBase64(buffer) {

This comment was marked as abuse.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not certain that module can do this stuff, i cant seem to find any useful documentation on it either

}

fileInfo(args) {
if (args.FORMAT === "size formatted") return FileSize;

This comment was marked as abuse.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really see a need to cast this?

@SharkPool-SP
Copy link
Collaborator Author

!format

@SharkPool-SP SharkPool-SP marked this pull request as draft June 8, 2025 06:33
@SharkPool-SP
Copy link
Collaborator Author

this must be merged first before this can be officially PR-ed:
TurboWarp/scratch-gui#979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: change existing extension Pull requests that change an existing extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants