-
Notifications
You must be signed in to change notification settings - Fork 295
files.js -- Update with code from Files Expanded #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
!format |
This comment was marked as abuse.
This comment was marked as abuse.
|
Ah, someone that actually knows what they are doing. I'm just going to close mine, since this does everything that mine would do (and better). |
This comment was marked as abuse.
This comment was marked as abuse.
!format |
!format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more indepth review is indeed required.
* @param {Uint8Array} buffer | ||
* @returns {string} base64 | ||
*/ | ||
function bufferToBase64(buffer) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not certain that module can do this stuff, i cant seem to find any useful documentation on it either
} | ||
|
||
fileInfo(args) { | ||
if (args.FORMAT === "size formatted") return FileSize; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont really see a need to cast this?
!format |
this must be merged first before this can be officially PR-ed: |
THIS MUST BE MERGED FIRST:
TurboWarp/scratch-gui#979
Super Mega Update to the Files Extension to port over many new features from my expansion of the extension.
This includes:
Closes:
#1603
#156
#837
Files Expanded:
https://github.com/SharkPool-SP/SharkPools-Extensions/blob/main/extension-code/Files-Expanded.js